]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Repair missing "checkfirst" for test suite
authorMike Bayer <mike_mp@zzzcomputing.com>
Tue, 7 Mar 2017 20:00:18 +0000 (15:00 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Tue, 7 Mar 2017 20:00:18 +0000 (15:00 -0500)
the test_metadata tests trigger the before_create dispatch without
the checkfirst flag.  Postgresql backend should be able to
tolerate this.

Change-Id: Ife497cc3a4eb2812462116f94aad732864225f3f

lib/sqlalchemy/dialects/postgresql/base.py
test/sql/test_metadata.py

index aaaa64cf16603e1f5dbf1aa15b3907a12459b427..db52642f83dc39bcac771024605e0da6197c1f30 100644 (file)
@@ -1245,24 +1245,24 @@ class ENUM(sqltypes.Enum):
         else:
             return False
 
-    def _on_table_create(self, target, bind, checkfirst, **kw):
+    def _on_table_create(self, target, bind, checkfirst=False, **kw):
         if checkfirst or (
                 not self.metadata and
                 not kw.get('_is_metadata_operation', False)) and \
                 not self._check_for_name_in_memos(checkfirst, kw):
             self.create(bind=bind, checkfirst=checkfirst)
 
-    def _on_table_drop(self, target, bind, checkfirst, **kw):
+    def _on_table_drop(self, target, bind, checkfirst=False, **kw):
         if not self.metadata and \
             not kw.get('_is_metadata_operation', False) and \
                 not self._check_for_name_in_memos(checkfirst, kw):
             self.drop(bind=bind, checkfirst=checkfirst)
 
-    def _on_metadata_create(self, target, bind, checkfirst, **kw):
+    def _on_metadata_create(self, target, bind, checkfirst=False, **kw):
         if not self._check_for_name_in_memos(checkfirst, kw):
             self.create(bind=bind, checkfirst=checkfirst)
 
-    def _on_metadata_drop(self, target, bind, checkfirst, **kw):
+    def _on_metadata_drop(self, target, bind, checkfirst=False, **kw):
         if not self._check_for_name_in_memos(checkfirst, kw):
             self.drop(bind=bind, checkfirst=checkfirst)
 
index 56ef8e62898a48392b0df254164b7a41bc52fe25..bd67b6f69b25720fc20678ccb6919a4957fbbc1c 100644 (file)
@@ -1532,6 +1532,7 @@ class PKAutoIncrementTest(fixtures.TestBase):
 
 
 class SchemaTypeTest(fixtures.TestBase):
+    __backend__ = True
 
     class TrackEvents(object):
         column = None