]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
Cleanup: Clarify the number meanings of string length.
authorKen'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Thu, 25 Jun 2009 00:12:00 +0000 (09:12 +0900)
committerDhaval Giani <dhaval@linux.vnet.ibm.com>
Mon, 29 Jun 2009 11:23:21 +0000 (16:53 +0530)
Hi,

This patch clarifies the number meanings of string length in the function
cgroup_get_uid_gid_from_procfs(). This is recreated based on Igawa-san's
patch for the latest code.

* Reference
  Igawa-san's patch
  http://sourceforge.net/mailarchive/message.php?msg_name=20090515.085922.109268324.igawa%40mxs.nes.nec.co.jp

Signed-off-by: Masayuki Igawa <igawa@mxs.nes.nec.co.jp>
Signed-off-by: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Signed-off-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
src/api.c

index 353b6dcebb92a3f3b13ead765a96b4546ce474f1..ee299c69d8769d9f335155f737e33b22653b5f51 100644 (file)
--- a/src/api.c
+++ b/src/api.c
@@ -2720,15 +2720,15 @@ int cgroup_get_uid_gid_from_procfs(pid_t pid, uid_t *euid, gid_t *egid)
 
        while (fgets(buf, sizeof(buf), f)) {
                if (!strncmp(buf, "Uid:", 4)) {
-                       if (sscanf((buf + 5), "%d%d%d%d", &ruid, euid,
-                                       &suid, &fsuid) != 4)
+                       if (sscanf((buf + strlen("Uid:") + 1), "%d%d%d%d",
+                                       &ruid, euid, &suid, &fsuid) != 4)
                                break;
                        cgroup_dbg("Scanned proc values are %d %d %d %d\n",
                                ruid, *euid, suid, fsuid);
                        found_euid = true;
                } else if (!strncmp(buf, "Gid:", 4)) {
-                       if (sscanf((buf + 5), "%d%d%d%d", &rgid, egid,
-                                       &sgid, &fsgid) != 4)
+                       if (sscanf((buf + strlen("Gid:") + 1), "%d%d%d%d",
+                                       &rgid, egid, &sgid, &fsgid) != 4)
                                break;
                        cgroup_dbg("Scanned proc values are %d %d %d %d\n",
                                rgid, *egid, sgid, fsgid);