]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed
authorYe Yin <hustcat@gmail.com>
Thu, 26 Oct 2017 08:57:05 +0000 (16:57 +0800)
committerSasha Levin <alexander.levin@verizon.com>
Thu, 7 Dec 2017 02:20:14 +0000 (21:20 -0500)
[ Upstream commit 2b5ec1a5f9738ee7bf8f5ec0526e75e00362c48f ]

When run ipvs in two different network namespace at the same host, and one
ipvs transport network traffic to the other network namespace ipvs.
'ipvs_property' flag will make the second ipvs take no effect. So we should
clear 'ipvs_property' when SKB network namespace changed.

Fixes: 621e84d6f373 ("dev: introduce skb_scrub_packet()")
Signed-off-by: Ye Yin <hustcat@gmail.com>
Signed-off-by: Wei Zhou <chouryzhou@gmail.com>
Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
include/linux/skbuff.h
net/core/skbuff.c

index ca2e26a486ee9c0aa37fb470f794b81a93c095e0..495ad8fbe240ab90575dd00e264eb106a884b469 100644 (file)
@@ -3230,6 +3230,13 @@ static inline void nf_reset_trace(struct sk_buff *skb)
 #endif
 }
 
+static inline void ipvs_reset(struct sk_buff *skb)
+{
+#if IS_ENABLED(CONFIG_IP_VS)
+       skb->ipvs_property = 0;
+#endif
+}
+
 /* Note: This doesn't put any conntrack and bridge info in dst. */
 static inline void __nf_copy(struct sk_buff *dst, const struct sk_buff *src,
                             bool copy)
index c9793c6c5005f1327eed932327c2f950fa78f1ac..2894bb5b7e0a0127fd45ee2de9fa722b2b0c823e 100644 (file)
@@ -4159,6 +4159,7 @@ void skb_scrub_packet(struct sk_buff *skb, bool xnet)
        if (!xnet)
                return;
 
+       ipvs_reset(skb);
        skb_orphan(skb);
        skb->mark = 0;
 }