]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: dac: vf610: Simplify with devm_clk_get_enabled()
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sun, 13 Jul 2025 15:59:58 +0000 (17:59 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 14 Jul 2025 18:20:54 +0000 (19:20 +0100)
Driver is getting clock and almost immediately enabling it, with no
relevant code executed between, thus the probe path and cleanups can be
simplified with devm_clk_get_enabled().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20250713-iio-clk-get-enabled-v1-4-70abc1f9ce6c@linaro.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/vf610_dac.c

index ddf90ae65a2c2458ccd4fa855f3dc56b923aaaa6..93639599b2b9895ed3307907216697d05cbc2d79 100644 (file)
@@ -188,7 +188,7 @@ static int vf610_dac_probe(struct platform_device *pdev)
        if (IS_ERR(info->regs))
                return PTR_ERR(info->regs);
 
-       info->clk = devm_clk_get(&pdev->dev, "dac");
+       info->clk = devm_clk_get_enabled(&pdev->dev, "dac");
        if (IS_ERR(info->clk))
                return dev_err_probe(&pdev->dev, PTR_ERR(info->clk),
                                     "Failed getting clock\n");
@@ -203,13 +203,6 @@ static int vf610_dac_probe(struct platform_device *pdev)
 
        mutex_init(&info->lock);
 
-       ret = clk_prepare_enable(info->clk);
-       if (ret) {
-               dev_err(&pdev->dev,
-                       "Could not prepare or enable the clock\n");
-               return ret;
-       }
-
        vf610_dac_init(info);
 
        ret = iio_device_register(indio_dev);
@@ -222,7 +215,6 @@ static int vf610_dac_probe(struct platform_device *pdev)
 
 error_iio_device_register:
        vf610_dac_exit(info);
-       clk_disable_unprepare(info->clk);
 
        return ret;
 }
@@ -234,7 +226,6 @@ static void vf610_dac_remove(struct platform_device *pdev)
 
        iio_device_unregister(indio_dev);
        vf610_dac_exit(info);
-       clk_disable_unprepare(info->clk);
 }
 
 static int vf610_dac_suspend(struct device *dev)