]> git.ipfire.org Git - thirdparty/grub.git/commitdiff
script/execute: Add missing grub_strdup() failure check
authorAvnish Chouhan <avnish@linux.ibm.com>
Mon, 10 Nov 2025 14:57:20 +0000 (20:27 +0530)
committerDaniel Kiper <daniel.kiper@oracle.com>
Tue, 18 Nov 2025 11:49:31 +0000 (12:49 +0100)
If grub_strdup() fails, it returns NULL and passing NULL further down to
the code can lead to segmentation fault or an undefined behavior.

Signed-off-by: Avnish Chouhan <avnish@linux.ibm.com>
Reviewed-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
grub-core/script/execute.c

index da99dfa050e8c30cfff7076f809018d2d5c70dfd..62afcdc99167c2ab9f1b888fdbcf59b27996f7ac 100644 (file)
@@ -1015,6 +1015,9 @@ grub_script_execute_cmdline (struct grub_script_cmd *cmd)
        {
          /* As a last resort, try if it is an assignment.  */
          char *assign = grub_strdup (cmdname);
+          if (assign == NULL)
+            return grub_errno;
+
          char *eq = grub_strchr (assign, '=');
 
          if (eq)