]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
dcb: fully initialize flag table
authorStephen Hemminger <stephen@networkplumber.org>
Wed, 28 Jun 2023 23:31:33 +0000 (16:31 -0700)
committerStephen Hemminger <stephen@networkplumber.org>
Wed, 28 Jun 2023 23:31:33 +0000 (16:31 -0700)
And make the flag table const since only used for lookup.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
dcb/dcb_dcbx.c

index 244b671b893b2954bddcd724da232b9f37e6d2ca..9e3dd2a0af876588117107292e2d0fcf72661408 100644 (file)
@@ -42,12 +42,12 @@ struct dcb_dcbx_flag {
        const char *key_json;
 };
 
-static struct dcb_dcbx_flag dcb_dcbx_flags[] = {
-       {DCB_CAP_DCBX_HOST, "host"},
-       {DCB_CAP_DCBX_LLD_MANAGED, "lld-managed", "lld_managed"},
-       {DCB_CAP_DCBX_VER_CEE, "cee"},
-       {DCB_CAP_DCBX_VER_IEEE, "ieee"},
-       {DCB_CAP_DCBX_STATIC, "static"},
+static const struct dcb_dcbx_flag dcb_dcbx_flags[] = {
+       {DCB_CAP_DCBX_HOST, "host", NULL },
+       {DCB_CAP_DCBX_LLD_MANAGED, "lld-managed", "lld_managed" },
+       {DCB_CAP_DCBX_VER_CEE, "cee", NULL },
+       {DCB_CAP_DCBX_VER_IEEE, "ieee", NULL },
+       {DCB_CAP_DCBX_STATIC, "static", NULL },
 };
 
 static void dcb_dcbx_print(__u8 dcbx)
@@ -60,7 +60,7 @@ static void dcb_dcbx_print(__u8 dcbx)
 
                bit--;
                for (i = 0; i < ARRAY_SIZE(dcb_dcbx_flags); i++) {
-                       struct dcb_dcbx_flag *flag = &dcb_dcbx_flags[i];
+                       const struct dcb_dcbx_flag *flag = &dcb_dcbx_flags[i];
 
                        if (flag->value == 1 << bit) {
                                print_bool(PRINT_JSON, flag->key_json ?: flag->key_fp,
@@ -123,7 +123,7 @@ static int dcb_cmd_dcbx_set(struct dcb *dcb, const char *dev, int argc, char **a
                }
 
                for (i = 0; i < ARRAY_SIZE(dcb_dcbx_flags); i++) {
-                       struct dcb_dcbx_flag *flag = &dcb_dcbx_flags[i];
+                       const struct dcb_dcbx_flag *flag = &dcb_dcbx_flags[i];
 
                        if (matches(*argv, flag->key_fp) == 0) {
                                dcbx |= flag->value;