]> git.ipfire.org Git - thirdparty/apache/httpd.git/commitdiff
mod_crypto: Fix warnings about signed bit fields.
authorYann Ylavic <ylavic@apache.org>
Thu, 14 Mar 2024 14:54:59 +0000 (14:54 +0000)
committerYann Ylavic <ylavic@apache.org>
Thu, 14 Mar 2024 14:54:59 +0000 (14:54 +0000)
The non-zero value for one bit field is -1:

mod_crypto.c|565 col 18| error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
||     ctx->encrypt = 1;
||                  ^ ~
mod_crypto.c|746 col 22| error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
||         ctx->clength = 1;
||                      ^ ~
mod_crypto.c|903 col 35| error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
||                     ctx->seen_eos = 1;
||                                   ^ ~
mod_crypto.c|960 col 22| error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
||         ctx->clength = 1;
||                      ^ ~

Use unsigned bit fields for struct crypto_ctx's members seen_eos, encrypt and clength.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1916299 13f79535-47bb-0310-9956-ffa450edef68

modules/filters/mod_crypto.c

index 2c98692c4160f215e92525513f00e4fc7dba877b..bd383e68085cd0eabdc4352e15de0068ea8506a1 100644 (file)
@@ -108,9 +108,9 @@ typedef struct crypto_ctx
     apr_off_t remaining;
     apr_off_t written;
     apr_size_t osize;
-    int seen_eos:1;
-    int encrypt:1;
-    int clength:1;
+    unsigned int seen_eos   :1,
+                 encrypt    :1,
+                 clength    :1;
 } crypto_ctx;
 
 static const char *parse_pass_conf_binary(cmd_parms *cmd,