]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mmc: mtk-sd: Re-store SDIO IRQs mask at system resume
authorUlf Hansson <ulf.hansson@linaro.org>
Wed, 11 Sep 2019 12:09:20 +0000 (14:09 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Oct 2019 11:13:57 +0000 (13:13 +0200)
[ Upstream commit 1c81d69d4c98aab56c5a7d5a810f84aefdb37e9b ]

In cases when SDIO IRQs have been enabled, runtime suspend is prevented by
the driver. However, this still means msdc_runtime_suspend|resume() gets
called during system suspend/resume, via pm_runtime_force_suspend|resume().

This means during system suspend/resume, the register context of the mtk-sd
device most likely loses its register context, even in cases when SDIO IRQs
have been enabled.

To re-enable the SDIO IRQs during system resume, the mtk-sd driver
currently relies on the mmc core to re-enable the SDIO IRQs when it resumes
the SDIO card, but this isn't the recommended solution. Instead, it's
better to deal with this locally in the mtk-sd driver, so let's do that.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/host/mtk-sd.c

index 33f4b6387ef714b0683fb0c9ef83394fcc94ca56..978c8ccce7e31e319151ae81c0ee25bd1dba78e6 100644 (file)
@@ -2421,6 +2421,9 @@ static void msdc_restore_reg(struct msdc_host *host)
        } else {
                writel(host->save_para.pad_tune, host->base + tune_reg);
        }
+
+       if (sdio_irq_claimed(host->mmc))
+               __msdc_enable_sdio_irq(host, 1);
 }
 
 static int msdc_runtime_suspend(struct device *dev)