]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
util: fix memory leak in virSocketAddrFormatFull
authorYi Wang <wang.yi59@zte.com.cn>
Fri, 26 May 2017 02:12:45 +0000 (22:12 -0400)
committerErik Skultety <eskultet@redhat.com>
Fri, 26 May 2017 10:15:13 +0000 (12:15 +0200)
The @ipv6_host allocated in virAsprintf may be lost when virAsprintf
addrstr failed.

Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Signed-off-by: Erik Skultety <eskultet@redhat.com>
src/util/virsocketaddr.c

index 9dffbc7360866147a437966ec63d6bd5b6fb280a..95b527436851571fbb8c2de8df7d93197b5cceee 100644 (file)
@@ -417,8 +417,10 @@ virSocketAddrFormatFull(const virSocketAddr *addr,
 
         if (virAsprintf(&addrstr, "%s%s%s",
                         ipv6_host ? ipv6_host : host,
-                        separator ? separator : ":", port) == -1)
+                        separator ? separator : ":", port) == -1) {
+            VIR_FREE(ipv6_host);
             goto error;
+        }
 
         VIR_FREE(ipv6_host);
     } else {