]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
Remove the print_vector_info gdbarch hook
authorTom Tromey <tom@tromey.com>
Sun, 3 Nov 2024 22:18:30 +0000 (15:18 -0700)
committerTom Tromey <tom@tromey.com>
Sat, 7 Feb 2026 14:56:28 +0000 (07:56 -0700)
The print_vector_info gdbarch hook has apparently never been set by
any arch.  This patch removes it.

gdb/gdbarch-gen.c
gdb/gdbarch-gen.h
gdb/gdbarch_components.py
gdb/infcmd.c

index 16292f54017cbf4a165c607f3dfc971bca4e8d43..15311ec1894a323d25df4d5bc62c1b605cde2837 100644 (file)
@@ -96,7 +96,6 @@ struct gdbarch
   gdbarch_code_of_frame_writable_ftype *code_of_frame_writable = default_code_of_frame_writable;
   gdbarch_print_registers_info_ftype *print_registers_info = default_print_registers_info;
   gdbarch_print_float_info_ftype *print_float_info = default_print_float_info;
-  gdbarch_print_vector_info_ftype *print_vector_info = nullptr;
   gdbarch_register_sim_regno_ftype *register_sim_regno = legacy_register_sim_regno;
   gdbarch_cannot_fetch_register_ftype *cannot_fetch_register = cannot_register_not;
   gdbarch_cannot_store_register_ftype *cannot_store_register = cannot_register_not;
@@ -355,7 +354,6 @@ verify_gdbarch (struct gdbarch *gdbarch)
   /* Skip verify of code_of_frame_writable, invalid_p == 0.  */
   /* Skip verify of print_registers_info, invalid_p == 0.  */
   /* Skip verify of print_float_info, invalid_p == 0.  */
-  /* Skip verify of print_vector_info, has predicate.  */
   /* Skip verify of register_sim_regno, invalid_p == 0.  */
   /* Skip verify of cannot_fetch_register, invalid_p == 0.  */
   /* Skip verify of cannot_store_register, invalid_p == 0.  */
@@ -733,12 +731,6 @@ gdbarch_dump (struct gdbarch *gdbarch, struct ui_file *file)
   gdb_printf (file,
              "gdbarch_dump: print_float_info = <%s>\n",
              host_address_to_string (gdbarch->print_float_info));
-  gdb_printf (file,
-             "gdbarch_dump: gdbarch_print_vector_info_p() = %d\n",
-             gdbarch_print_vector_info_p (gdbarch));
-  gdb_printf (file,
-             "gdbarch_dump: print_vector_info = <%s>\n",
-             host_address_to_string (gdbarch->print_vector_info));
   gdb_printf (file,
              "gdbarch_dump: register_sim_regno = <%s>\n",
              host_address_to_string (gdbarch->register_sim_regno));
@@ -2311,30 +2303,6 @@ set_gdbarch_print_float_info (struct gdbarch *gdbarch,
   gdbarch->print_float_info = print_float_info;
 }
 
-bool
-gdbarch_print_vector_info_p (struct gdbarch *gdbarch)
-{
-  gdb_assert (gdbarch != NULL);
-  return gdbarch->print_vector_info != NULL;
-}
-
-void
-gdbarch_print_vector_info (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, const char *args)
-{
-  gdb_assert (gdbarch != NULL);
-  gdb_assert (gdbarch->print_vector_info != NULL);
-  if (gdbarch_debug >= 2)
-    gdb_printf (gdb_stdlog, "gdbarch_print_vector_info called\n");
-  gdbarch->print_vector_info (gdbarch, file, frame, args);
-}
-
-void
-set_gdbarch_print_vector_info (struct gdbarch *gdbarch,
-                              gdbarch_print_vector_info_ftype print_vector_info)
-{
-  gdbarch->print_vector_info = print_vector_info;
-}
-
 int
 gdbarch_register_sim_regno (struct gdbarch *gdbarch, int reg_nr)
 {
index 2cfb992499f67f78b1ab7b39eb4657df1f43ff87..d17f43ce59acd532fe996792f85b05b6a374fefd 100644 (file)
@@ -354,12 +354,6 @@ typedef void (gdbarch_print_float_info_ftype) (struct gdbarch *gdbarch, struct u
 extern void gdbarch_print_float_info (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, const char *args);
 extern void set_gdbarch_print_float_info (struct gdbarch *gdbarch, gdbarch_print_float_info_ftype *print_float_info);
 
-extern bool gdbarch_print_vector_info_p (struct gdbarch *gdbarch);
-
-typedef void (gdbarch_print_vector_info_ftype) (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, const char *args);
-extern void gdbarch_print_vector_info (struct gdbarch *gdbarch, struct ui_file *file, const frame_info_ptr &frame, const char *args);
-extern void set_gdbarch_print_vector_info (struct gdbarch *gdbarch, gdbarch_print_vector_info_ftype *print_vector_info);
-
 /* MAP a GDB RAW register number onto a simulator register number.  See
    also include/...-sim.h. */
 
index d3dc0d5870710ed1165a0f5418ba334b4438af58..64dd7c11c1200fe79f5d1b329738fb1b298a1b5f 100644 (file)
@@ -686,17 +686,6 @@ Method(
     invalid=False,
 )
 
-Method(
-    type="void",
-    name="print_vector_info",
-    params=[
-        ("struct ui_file *", "file"),
-        ("const frame_info_ptr &", "frame"),
-        ("const char *", "args"),
-    ],
-    predicate=True,
-)
-
 Method(
     comment="""
 MAP a GDB RAW register number onto a simulator register number.  See
index 65c39d53e6e36d5f1dcb24096c26532ff734a216..871eeba1850381060166dd173f279bb11b2d8b13 100644 (file)
@@ -2639,25 +2639,18 @@ print_vector_info (struct ui_file *file,
                   const frame_info_ptr &frame, const char *args)
 {
   struct gdbarch *gdbarch = get_frame_arch (frame);
+  bool printed_something = false;
 
-  if (gdbarch_print_vector_info_p (gdbarch))
-    gdbarch_print_vector_info (gdbarch, file, frame, args);
-  else
+  for (int regnum = 0; regnum < gdbarch_num_cooked_regs (gdbarch); regnum++)
     {
-      int regnum;
-      int printed_something = 0;
-
-      for (regnum = 0; regnum < gdbarch_num_cooked_regs (gdbarch); regnum++)
+      if (gdbarch_register_reggroup_p (gdbarch, regnum, vector_reggroup))
        {
-         if (gdbarch_register_reggroup_p (gdbarch, regnum, vector_reggroup))
-           {
-             printed_something = 1;
-             gdbarch_print_registers_info (gdbarch, file, frame, regnum, 1);
-           }
+         printed_something = true;
+         gdbarch_print_registers_info (gdbarch, file, frame, regnum, 1);
        }
-      if (!printed_something)
-       gdb_printf (file, "No vector information\n");
     }
+  if (!printed_something)
+    gdb_printf (file, "No vector information\n");
 }
 
 static void