json: Fix memleak in timeout_policy_json()

Use the correct function when populating policy property value,
otherwise the temporary objects' refcounts are incremented.

Fixes: c82a26ebf7e9f ("json: Add ct timeout support")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/src/json.c b/src/json.c
index 96ba557a3478b272b4d9d74f98a07bfe4d031aa7..33e0ec15f2ee1fe15853bc546b2ea9e2bb579574 100644 (file)
--- a/src/json.c
+++ b/src/json.c
@@ -266,8 +266,8 @@ static json_t *timeout_policy_json(uint8_t l4, const uint32_t *timeout)
 
                if (!root)
                        root = json_object();
-               json_object_set(root, timeout_protocol[l4].state_to_name[i],
-                               json_integer(timeout[i]));
+               json_object_set_new(root, timeout_protocol[l4].state_to_name[i],
+                                   json_integer(timeout[i]));
        }
        return root ? : json_null();
 }