]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
dns scavenging: tighten lifetime of filtered records
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Mon, 14 Jun 2021 11:16:46 +0000 (23:16 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Sun, 20 Jun 2021 23:26:32 +0000 (23:26 +0000)
We were ending up with everything lasting as long as
kccsrv_periodic_run(), which could add to quite a pile.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/kcc/scavenge_dns_records.c

index db341364902a72419feb84961d687451302cf400..e31e7ec324f5c66cb00917c18242a0bed3008668 100644 (file)
@@ -196,7 +196,7 @@ static NTSTATUS dns_tombstone_records_zone(TALLOC_CTX *mem_ctx,
                        return NT_STATUS_INTERNAL_ERROR;
                }
 
-               status = copy_current_records(mem_ctx, old_el, el, dns_timestamp);
+               status = copy_current_records(new_msg, old_el, el, dns_timestamp);
 
                if (!NT_STATUS_IS_OK(status)) {
                        TALLOC_FREE(new_msg);