]> git.ipfire.org Git - thirdparty/snort3.git/commitdiff
latest from josh
authorRuss Combs <rucombs@cisco.com>
Wed, 10 Sep 2014 22:18:56 +0000 (18:18 -0400)
committerRuss Combs <rucombs@cisco.com>
Wed, 10 Sep 2014 22:18:56 +0000 (18:18 -0400)
ChangeLog
src/flow/flow_control.cc
src/managers/inspector_manager.cc
src/stream/tcp/tcp_session.cc

index 9b82ea6d3b6ed90fab7bc8e40a110ca96c9d268e..e35e365c9c0313642921c458f2ab05a22f2460b9 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -3,6 +3,7 @@
 -- fixed packet direction
 -- added default service bindings when wizard is configured but binder is not
 -- updated snort.lua
+-- latest from Josh
 
 118
 -- fixed bind action
index c4091868681f0608625114e2178a83630be0775a..9efce71d24900ea94006c8a9ce2b5f84b79cc657 100644 (file)
@@ -37,6 +37,7 @@
 #include "protocols/layer.h"
 #include "protocols/vlan.h"
 #include "managers/inspector_manager.h"
+#include "sfip/sf_ip.h"
 
 FlowControl::FlowControl(Inspector* pi)
 {
index 3d5d62d9c1a3fc0232091ce052be19d36d15299b..808ffb11a5fe033309d363abb707e51b9ebab5d9 100644 (file)
@@ -494,7 +494,7 @@ static void instantiate_binder(SnortConfig* sc, FrameworkPolicy* fp)
     if ( tcp )
         m->add(PROTO_BIT__TCP, wiz_id);
 
-//    if ( udp )
+    if ( udp )
         m->add(PROTO_BIT__UDP, wiz_id);
 
     const InspectApi* api = get_plugin(bind_id);
index d809ebdb2f93b852c0bdb3e82b84401e4717945f..6a3dccf78a830643798faf1bc8149711ce92fe6f 100644 (file)
@@ -5777,9 +5777,8 @@ static inline uint32_t GetForwardDir (const Packet* p)
 // the key difference is that we operate on forward moving data
 // because we don't wait until it is acknowledged
 static inline uint32_t flush_pdu_ips (
-    TcpSession* ssn, StreamTracker* trk, Packet* pkt, uint32_t* flags)
+    TcpSession* ssn, StreamTracker* trk, uint32_t* flags)
 {
-    bool to_srv = ( *flags == PKT_FROM_CLIENT );
     uint32_t total = 0, avail;
     StreamSegment* seg;
     PROFILE_VARS;
@@ -5849,7 +5848,7 @@ static inline int CheckFlushPolicyOnData(
         case STREAM_FLPOLICY_ON_DATA:
         {
             uint32_t flags = GetForwardDir(p);
-            uint32_t flush_amt = flush_pdu_ips(tcpssn, listener, p, &flags);
+            uint32_t flush_amt = flush_pdu_ips(tcpssn, listener, &flags);
             uint32_t this_flush;
 
             while ( flush_amt > 0 )
@@ -5881,7 +5880,7 @@ static inline int CheckFlushPolicyOnData(
 
                 flushed += this_flush;
                 flags = GetForwardDir(p);
-                flush_amt = flush_pdu_ips(tcpssn, listener, p, &flags);
+                flush_amt = flush_pdu_ips(tcpssn, listener, &flags);
             }
             if ( !flags && listener->splitter->is_paf() )
             {
@@ -5916,9 +5915,8 @@ static inline int CheckFlushPolicyOnData(
 //   know where we left off and can resume scanning the remainder
 
 static inline uint32_t flush_pdu_ackd (
-    TcpSession* ssn, StreamTracker* trk, Packet* pkt, uint32_t* flags)
+    TcpSession* ssn, StreamTracker* trk, uint32_t* flags)
 {
-    bool to_srv = ( *flags == PKT_FROM_CLIENT );
     uint32_t total = 0;
     StreamSegment* seg;
     PROFILE_VARS;
@@ -5988,7 +5986,7 @@ int CheckFlushPolicyOnAck(
         case STREAM_FLPOLICY_ON_ACK:
         {
             uint32_t flags = GetReverseDir(p);
-            uint32_t flush_amt = flush_pdu_ackd(tcpssn, talker, p, &flags);
+            uint32_t flush_amt = flush_pdu_ackd(tcpssn, talker, &flags);
 
             while ( flush_amt > 0 )
             {
@@ -6010,7 +6008,7 @@ int CheckFlushPolicyOnAck(
                     break;
 
                 flags = GetReverseDir(p);
-                flush_amt = flush_pdu_ackd(tcpssn, talker, p, &flags);
+                flush_amt = flush_pdu_ackd(tcpssn, talker, &flags);
             }
             if ( !flags && talker->splitter->is_paf() )
             {