]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: mana: Fix memory leak in mana_gd_setup_irqs
authorMaxim Levitsky <mlevitsk@redhat.com>
Mon, 9 Dec 2024 17:57:50 +0000 (12:57 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Dec 2024 17:13:18 +0000 (18:13 +0100)
[ Upstream commit bb1e3eb57d2cc38951f9a9f1b8c298ced175798f ]

Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
added memory allocation in mana_gd_setup_irqs of 'irqs' but the code
doesn't free this temporary array in the success path.

This was caught by kmemleak.

Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>
Reviewed-by: Yury Norov <yury.norov@gmail.com>
Link: https://patch.msgid.link/20241209175751.287738-2-mlevitsk@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/microsoft/mana/gdma_main.c

index ca4ed58f1206dd6906905ab506211c4a0b5d02a9..42076c90ce875186f9c8ba028a1708a622d3c7bb 100644 (file)
@@ -1372,6 +1372,7 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev)
        gc->max_num_msix = nvec;
        gc->num_msix_usable = nvec;
        cpus_read_unlock();
+       kfree(irqs);
        return 0;
 
 free_irq: