]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
Don't crash when Set() is called without a value.
authorRussell Bryant <russell@russellbryant.com>
Thu, 7 Oct 2010 10:53:56 +0000 (10:53 +0000)
committerRussell Bryant <russell@russellbryant.com>
Thu, 7 Oct 2010 10:53:56 +0000 (10:53 +0000)
Review: https://reviewboard.asterisk.org/r/949/

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@290712 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/pbx.c

index 62c9d8d2fce0783d4b3dd77351d10b3665f5a899..9fb0c8bb01c6872d3bbbf182384426c9fda9737e 100644 (file)
@@ -9111,11 +9111,18 @@ int pbx_builtin_setvar(struct ast_channel *chan, void *data)
        mydata = ast_strdupa(data);
        name = strsep(&mydata, "=");
        value = mydata;
-       if (strchr(name, ' '))
+       if (!value) {
+               ast_log(LOG_WARNING, "Set requires an '=' to be a valid assignment.\n");
+               return 0;
+       }
+
+       if (strchr(name, ' ')) {
                ast_log(LOG_WARNING, "Please avoid unnecessary spaces on variables as it may lead to unexpected results ('%s' set to '%s').\n", name, mydata);
+       }
 
        pbx_builtin_setvar_helper(chan, name, value);
-       return(0);
+
+       return 0;
 }
 
 int pbx_builtin_setvar_multiple(struct ast_channel *chan, void *vdata)