]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
remove DNS_OVER_TLS guard around applying the dot-to-port-853 setting
authorPeter van Dijk <peter.van.dijk@powerdns.com>
Thu, 1 Jul 2021 20:36:50 +0000 (22:36 +0200)
committerPeter van Dijk <peter.van.dijk@powerdns.com>
Thu, 1 Jul 2021 20:36:52 +0000 (22:36 +0200)
before this commit: pointing a forward at port 853, without DoT support, causes Recursor to attempt to do UDP over port 853 to the upstream. This rarely works.

after this commit: much swifter failure with an error log message saying `45.55.10.200:853 requested but not available`

pdns/pdns_recursor.cc

index 8ec44fff7ed8845837ad83d377ff90119ece31f8..b08d5d9342609c95da700adfcc7cadde83409b02 100644 (file)
@@ -4883,9 +4883,7 @@ static int serviceMain(int argc, char*argv[])
   SyncRes::s_tcp_fast_open = ::arg().asNum("tcp-fast-open");
   SyncRes::s_tcp_fast_open_connect = ::arg().mustDo("tcp-fast-open-connect");
 
-#ifdef HAVE_DNS_OVER_TLS
   SyncRes::s_dot_to_port_853 = ::arg().mustDo("dot-to-port-853");
-#endif
 
   if (SyncRes::s_tcp_fast_open_connect) {
     checkFastOpenSysctl(true);