]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 1272546 - unauthenticated users cannot expand the cc list
authorDavid Lawrence <dkl@mozilla.com>
Tue, 31 May 2016 21:39:13 +0000 (21:39 +0000)
committerDavid Lawrence <dkl@mozilla.com>
Tue, 31 May 2016 21:39:19 +0000 (21:39 +0000)
extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl
extensions/BugModal/web/bug_modal.css
extensions/BugModal/web/bug_modal.js

index e1a57a1f622dc8d3b8697cc2380a4a8fb7f3973a..fd1359b3285613bed106a63782612f47f035bf99 100644 (file)
       [% END %]
 
       [% IF bug.cc && bug.cc.size %]
-        <input type="hidden" name="removecc" id="removecc">
-        <span id="cc-latch">&#9656;</span>
+        [% IF user.id %]
+          <input type="hidden" name="removecc" id="removecc">
+          <span id="cc-latch">&#9656;</span>
+        [% END %]
         <span id="cc-summary" data-count="[% bug.cc.size FILTER none %]">
           [%
             IF bug.cc.size == 1;
index 88ffadc9e47a58555697bf8dabb49a404972d777..b5e3c1a37fcb2b1ad2d045c7889daaa2daad1dbb 100644 (file)
@@ -326,14 +326,10 @@ input[type="number"] {
     color: #999;
 }
 
-#cc-latch, #cc-summary {
+#cc-latch {
     cursor: pointer;
 }
 
-#cc-summary:hover {
-    text-decoration: underline;
-}
-
 #cc-list {
     max-height: 150px;
     overflow-y: auto;
@@ -365,6 +361,14 @@ input[type="number"] {
     width: 100%;
 }
 
+.cc-loadable {
+    cursor: pointer;
+}
+
+.cc-loadable:hover {
+    text-decoration: underline;
+}
+
 /* actions */
 
 #top-actions {
index b3b378d26505999de11a28edc7e3e190df2d561d..46a00048208141033811c55b73c43843ce59d944 100644 (file)
@@ -226,24 +226,27 @@ $(function() {
         );
     }
 
-    $('#cc-latch, #cc-summary')
-        .click(function(event) {
-            event.preventDefault();
-            var latch = $('#cc-latch');
+    if (BUGZILLA.user.id) {
+        $('#cc-summary').addClass('cc-loadable');
+        $('#cc-latch, #cc-summary')
+            .click(function(event) {
+                event.preventDefault();
+                var latch = $('#cc-latch');
 
-            if (latch.data('expanded')) {
-                latch.data('expanded', false).html('&#9656;');
-                $('#cc-list').hide();
-            }
-            else {
-                latch.data('expanded', true).html('&#9662;');
-                $('#cc-list').show();
-                if (!latch.data('fetched')) {
-                    ccListLoading();
-                    ccListUpdate();
+                if (latch.data('expanded')) {
+                    latch.data('expanded', false).html('&#9656;');
+                    $('#cc-list').hide();
                 }
-            }
-        });
+                else {
+                    latch.data('expanded', true).html('&#9662;');
+                    $('#cc-list').show();
+                    if (!latch.data('fetched')) {
+                        ccListLoading();
+                        ccListUpdate();
+                    }
+                }
+            });
+    }
 
     // copy summary to clipboard