]> git.ipfire.org Git - thirdparty/elfutils.git/commitdiff
libdw: Make libdw_findcu thread-safe
authorHeather McIntyre <hsm2@rice.edu>
Tue, 16 Jul 2024 16:37:32 +0000 (12:37 -0400)
committerAaron Merey <amerey@redhat.com>
Wed, 21 Aug 2024 00:19:13 +0000 (20:19 -0400)
* libdw/libdw_findcu.c (__libdw_findcu): Add locking.

Signed-off-by: Heather S. McIntyre <hsm2@rice.edu>
Signed-off-by: Aaron Merey <amerey@redhat.com>
Signed-off-by: Mark Wielaard <mark@klomp.org>
libdw/libdw_findcu.c

index c74e895e16bd0754e7a511141973d640e9e37554..bbbbee5d74e57959e6f1f60cf5cd04bbeced3e4a 100644 (file)
@@ -245,27 +245,39 @@ __libdw_findcu (Dwarf *dbg, Dwarf_Off start, bool v4_debug_types)
   /* Maybe we already know that CU.  */
   struct Dwarf_CU fake = { .start = start, .end = 0 };
   struct Dwarf_CU **found = eu_tfind (&fake, tree, findcu_cb);
+  struct Dwarf_CU *result = NULL;
   if (found != NULL)
     return *found;
 
+  rwlock_wrlock (dbg->dwarf_lock);
+
   if (start < *next_offset)
+    __libdw_seterrno (DWARF_E_INVALID_DWARF);
+  else
     {
-      __libdw_seterrno (DWARF_E_INVALID_DWARF);
-      return NULL;
-    }
+      /* No.  Then read more CUs.  */
+      while (1)
+       {
+         struct Dwarf_CU *newp
+           = __libdw_intern_next_unit (dbg, v4_debug_types);
 
-  /* No.  Then read more CUs.  */
-  while (1)
-    {
-      struct Dwarf_CU *newp = __libdw_intern_next_unit (dbg, v4_debug_types);
-      if (newp == NULL)
-       return NULL;
+         if (newp == NULL)
+           {
+             result = NULL;
+             break;
+           }
 
-      /* Is this the one we are looking for?  */
-      if (start < *next_offset || start == newp->start)
-       return newp;
+         /* Is this the one we are looking for?  */
+         if (start < *next_offset || start == newp->start)
+           {
+             result = newp;
+             break;
+           }
+       }
     }
-  /* NOTREACHED */
+
+  rwlock_unlock (dbg->dwarf_lock);
+  return result;
 }
 
 struct Dwarf_CU *