]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: tps65912: check the return value of regmap_update_bits()
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 7 Jul 2025 07:50:15 +0000 (09:50 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Sun, 13 Jul 2025 08:45:04 +0000 (10:45 +0200)
regmap_update_bits() can fail, check its return value like we do
elsewhere in the driver.

Link: https://lore.kernel.org/r/20250707-gpiochip-set-rv-gpio-round4-v1-2-35668aaaf6d2@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-tps65912.c

index fab771cb6a87bf05b1edc3c062f846bea70ca825..bac757c191c2ea0d103eb0577710065611fd79aa 100644 (file)
@@ -49,10 +49,13 @@ static int tps65912_gpio_direction_output(struct gpio_chip *gc,
                                          unsigned offset, int value)
 {
        struct tps65912_gpio *gpio = gpiochip_get_data(gc);
+       int ret;
 
        /* Set the initial value */
-       regmap_update_bits(gpio->tps->regmap, TPS65912_GPIO1 + offset,
-                          GPIO_SET_MASK, value ? GPIO_SET_MASK : 0);
+       ret = regmap_update_bits(gpio->tps->regmap, TPS65912_GPIO1 + offset,
+                                GPIO_SET_MASK, value ? GPIO_SET_MASK : 0);
+       if (ret)
+               return ret;
 
        return regmap_update_bits(gpio->tps->regmap, TPS65912_GPIO1 + offset,
                                  GPIO_CFG_MASK, GPIO_CFG_MASK);