]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
firmware: cs_dsp: tests: Depend on FW_CS_DSP rather then enabling it
authorNico Pache <npache@redhat.com>
Fri, 11 Apr 2025 12:36:08 +0000 (13:36 +0100)
committerMark Brown <broonie@kernel.org>
Sun, 13 Apr 2025 19:20:30 +0000 (20:20 +0100)
FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather
depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the
depends on clause.

Fixes: dd0b6b1f29b9 ("firmware: cs_dsp: Add KUnit testing of bin file download")
Signed-off-by: Nico Pache <npache@redhat.com>
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20250411123608.1676462-4-rf@opensource.cirrus.com
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/firmware/cirrus/Kconfig

index 0a883091259a2c11830ab2d12a945a2a2b8f032b..e3c2e38b746df9b6cd694bce9d9e512fd15baf31 100644 (file)
@@ -6,14 +6,11 @@ config FW_CS_DSP
 
 config FW_CS_DSP_KUNIT_TEST_UTILS
        tristate
-       depends on KUNIT && REGMAP
-       select FW_CS_DSP
 
 config FW_CS_DSP_KUNIT_TEST
        tristate "KUnit tests for Cirrus Logic cs_dsp" if !KUNIT_ALL_TESTS
-       depends on KUNIT && REGMAP
+       depends on KUNIT && REGMAP && FW_CS_DSP
        default KUNIT_ALL_TESTS
-       select FW_CS_DSP
        select FW_CS_DSP_KUNIT_TEST_UTILS
        help
          This builds KUnit tests for cs_dsp.