]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
regmap: fix possible ZERO_SIZE_PTR pointer dereferencing error.
authorXiubo Li <Li.Xiubo@freescale.com>
Sun, 28 Sep 2014 09:09:54 +0000 (17:09 +0800)
committerJiri Slaby <jslaby@suse.cz>
Fri, 31 Oct 2014 14:11:11 +0000 (15:11 +0100)
commit d6b41cb06044a7d895db82bdd54f6e4219970510 upstream.

Since we cannot make sure the 'val_count' will always be none zero
here, and then if it equals to zero, the kmemdup() will return
ZERO_SIZE_PTR, which equals to ((void *)16).

So this patch fix this with just doing the zero check before calling
kmemdup().

Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/base/regmap/regmap.c

index cd5c5bffac87a73aabbba9f81c96662bafcc4cec..7a58be457eb52d999b0d6fe0ce8c5aa122834a93 100644 (file)
@@ -1403,6 +1403,9 @@ int regmap_bulk_write(struct regmap *map, unsigned int reg, const void *val,
        if (val_bytes == 1) {
                wval = (void *)val;
        } else {
+               if (!val_count)
+                       return -EINVAL;
+
                wval = kmemdup(val, val_count * val_bytes, GFP_KERNEL);
                if (!wval) {
                        ret = -ENOMEM;