]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[5469] Minor corrections as a result of review, mainly docs.
authorMarcin Siodelski <marcin@isc.org>
Mon, 5 Mar 2018 20:31:54 +0000 (21:31 +0100)
committerMarcin Siodelski <marcin@isc.org>
Mon, 5 Mar 2018 20:31:54 +0000 (21:31 +0100)
src/hooks/dhcp/lease_cmds/lease_cmds.cc
src/hooks/dhcp/lease_cmds/lease_cmds.h
src/hooks/dhcp/lease_cmds/tests/lease_cmds_unittest.cc
src/lib/dhcpsrv/cql_lease_mgr.h

index 7c8b01aa73b4e1cfb47f14ffe82065cc5de399b2..c0d593534bd155f2a7a44182deb750d351476827 100644 (file)
@@ -130,9 +130,9 @@ public:
     int
     leaseGetHandler(CalloutHandle& handle);
 
-    /// @brief lease4-get-all, lease6-get-all command handler
+    /// @brief lease4-get-all, lease6-get-all commands handler
     ///
-    /// This command attempts to retrieve all IPv4 or IPv6 leases,
+    /// These commands attempt to retrieve all IPv4 or IPv6 leases,
     /// or all IPv4 or all IPv6 leases belonging to the particular
     /// subnets. If no subnet identifiers are provided, it returns all
     /// IPv4 or IPv6 leases from the database.
index 33d90106a6a1e3094547097c8cec468b5bfcc4ac..05450f0f136162fd58fd21c7c2dd75d45dc4b5bc 100644 (file)
@@ -131,9 +131,9 @@ public:
     int
     leaseGetHandler(hooks::CalloutHandle& handle);
 
-    /// @brief lease4-get-all, lease6-get-all command handler
+    /// @brief lease4-get-all, lease6-get-all commands handler
     ///
-    /// This command attempts to retrieve all IPv4 or IPv6 leases,
+    /// These commands attempt to retrieve all IPv4 or IPv6 leases,
     /// or all IPv4 or all IPv6 leases belonging to the particular
     /// subnets. If no subnet identifiers are provided, it returns all
     /// IPv4 or IPv6 leases from the database.
index b593042c83ac6d152a1677ad59795f1129016104..d7bc488ad60158df8b0fa5932bc1f7735deb0a36 100644 (file)
@@ -344,8 +344,8 @@ public:
         lease->preferred_lft_ = 1800;
         lease->valid_lft_ = 3600;
         lease->cltt_ = 12345678;
-        lease->subnet_id_ = subnet_id;;
-        lease->fqdn_fwd_ = true;
+        lease->subnet_id_ = subnet_id;
+        lease->fqdn_fwd_ = false;
         lease->fqdn_rev_ = true;
         lease->hostname_ = "myhost.example.com.";
 
index c699577d893dfa84c23c4be920d61feac0afa6b8..dde931a1034aef5e7acafdfc667ea476b5895ec2 100644 (file)
@@ -203,11 +203,15 @@ public:
     /// @param subnet_id subnet identifier.
     ///
     /// @return Lease collection (may be empty if no IPv4 lease found).
+    /// @throw NotImplemented because this method is currently not implemented for
+    /// this backend.
     virtual Lease4Collection getLeases4(SubnetID subnet_id) const;
 
     /// @brief Returns all IPv4 leases.
     ///
     /// @return Lease collection (may be empty if no IPv4 lease found).
+    /// @throw NotImplemented because this method is currently not implemented for
+    /// this backend.
     virtual Lease4Collection getLeases4() const;
 
     /// @brief Returns existing IPv6 lease for a given IPv6 address.
@@ -275,12 +279,16 @@ public:
     /// @param type specifies lease type: (NA, TA or PD)
     ///
     /// @return Lease collection (may be empty if no IPv6 lease found).
+    /// @throw NotImplemented because this method is currently not implemented for
+    /// this backend.
     virtual Lease6Collection getLeases6(SubnetID subnet_id,
                                         Lease::Type type) const;
 
     /// @brief Returns all IPv6 leases.
     ///
     /// @return Lease collection (may be empty if no IPv6 lease found).
+    /// @throw NotImplemented because this method is currently not implemented for
+    /// this backend.
     virtual Lease6Collection getLeases6() const;
 
     /// @brief Returns a collection of expired DHCPv6 leases.