]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: clps711x: remove redundant of_match_ptr()
authorZhu Wang <wangzhu9@huawei.com>
Wed, 2 Aug 2023 02:54:31 +0000 (10:54 +0800)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 3 Aug 2023 13:58:46 +0000 (15:58 +0200)
The driver depends on CONFIG_OF, so it is not necessary to use
of_match_ptr() here.

Even for drivers that do not depend on CONFIG_OF, it's almost always
better to leave out the of_match_ptr(), since the only thing it can
possibly do is to save a few bytes of .text if a driver can be used both
with and without it. Hence we remove of_match_ptr().

Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-clps711x.c

index 75f6f8d4323e9a30632bde6685693c055e4cdd50..d69a24dd4828975b4d62f66b011964456976bfa6 100644 (file)
@@ -67,7 +67,7 @@ static int clps711x_gpio_probe(struct platform_device *pdev)
        return devm_gpiochip_add_data(&pdev->dev, gc, NULL);
 }
 
-static const struct of_device_id __maybe_unused clps711x_gpio_ids[] = {
+static const struct of_device_id clps711x_gpio_ids[] = {
        { .compatible = "cirrus,ep7209-gpio" },
        { }
 };
@@ -76,7 +76,7 @@ MODULE_DEVICE_TABLE(of, clps711x_gpio_ids);
 static struct platform_driver clps711x_gpio_driver = {
        .driver = {
                .name           = "clps711x-gpio",
-               .of_match_table = of_match_ptr(clps711x_gpio_ids),
+               .of_match_table = clps711x_gpio_ids,
        },
        .probe  = clps711x_gpio_probe,
 };