re PR tree-optimization/60382 (ICE on valid code at -O3 on x86_64-linux-gnu (in vect_...

2014-03-04  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/60382
	* tree-vect-loop.c (vect_is_simple_reduction_1): Do not consider
	dead PHIs a reduction.

	* gcc.dg/vect/pr60382.c: New testcase.

From-SVN: r208310

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index de0ee76b0cb91c69abbbdf8bef43aad311d41c5e..f0b9daab896edd80863e6c09b2928847ee70146a 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2014-03-04  Richard Biener  <rguenther@suse.de>
+
+       PR tree-optimization/60382
+       * tree-vect-loop.c (vect_is_simple_reduction_1): Do not consider
+       dead PHIs a reduction.
+
 2014-02-25  Richard Biener  <rguenther@suse.de>
 
        Backport from mainline

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 20afe17b34f85173255870b90af124d90776c168..d58aae5d2100acf5560d178654808740b4f8987e 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2014-03-04  Richard Biener  <rguenther@suse.de>
+
+       PR tree-optimization/60382
+       * gcc.dg/vect/pr60382.c: New testcase.
+
 2014-03-02  Mikael Morin  <mikael@gcc.gnu.org>
 
        PR fortran/60341

diff --git a/gcc/testsuite/gcc.dg/vect/pr60382.c b/gcc/testsuite/gcc.dg/vect/pr60382.c
new file mode 100644 (file)
index 0000000..a28c631
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/vect/pr60382.c
@@ -0,0 +1,32 @@
+#include "tree-vect.h"
+
+int a, b, c, e, f;
+
+void
+foo ()
+{
+  for (b = 0; b < 3; b++)
+    if (e)
+      {
+       for (c = 0; c < 4; c++)
+         {
+           if (b)
+             continue;
+           f = 1;
+           for (a = 0; a < 2; a++)
+             f |= 1;
+         }
+       for (;;)
+         ;
+      }
+}
+
+int
+main ()
+{
+  check_vect ();
+  foo ();
+  return 0;
+}
+
+/* { dg-final { cleanup-tree-dump "vect" } } */

diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c
index b60ef1cfa85dc1d31a216de694806e0a30691014..8495287db671bf39d12421f260d0d0cd69c29672 100644 (file)
--- a/gcc/tree-vect-loop.c
+++ b/gcc/tree-vect-loop.c
@@ -2097,6 +2097,12 @@ vect_is_simple_reduction_1 (loop_vec_info loop_info, gimple phi,
               || (!check_reduction && flow_loop_nested_p (vect_loop, loop)));
 
   name = PHI_RESULT (phi);
+  /* ???  If there are no uses of the PHI result the inner loop reduction
+     won't be detected as possibly double-reduction by vectorizable_reduction
+     because that tries to walk the PHI arg from the preheader edge which
+     can be constant.  See PR60382.  */
+  if (has_zero_uses (name))
+    return NULL;
   nloop_uses = 0;
   FOR_EACH_IMM_USE_FAST (use_p, imm_iter, name)
     {