]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Input: cros_ec_keyb - clarify key event error message
authorFabio Baltieri <fabiobaltieri@chromium.org>
Tue, 9 Dec 2025 15:47:04 +0000 (15:47 +0000)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sat, 13 Dec 2025 09:39:46 +0000 (01:39 -0800)
Reword one of the key event error messages to clarify its meaning: it's
not necessarily an incomplete message, more of a mismatch length.
Clarify that and log the expected and received length too.

Signed-off-by: Fabio Baltieri <fabiobaltieri@chromium.org>
Reviewed-by: Simon Glass <simon.glass@canonical.com>
Link: https://patch.msgid.link/20251209154706.529784-2-fabiobaltieri@chromium.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/cros_ec_keyb.c

index 1c6b0461dc35475c963d936c68c02fb636ee8650..2822c592880b00095933144f213efbe874543f7d 100644 (file)
@@ -269,7 +269,8 @@ static int cros_ec_keyb_work(struct notifier_block *nb,
 
                if (ckdev->ec->event_size != ckdev->cols) {
                        dev_err(ckdev->dev,
-                               "Discarded incomplete key matrix event.\n");
+                               "Discarded key matrix event, unexpected length: %d != %d\n",
+                               ckdev->ec->event_size, ckdev->cols);
                        return NOTIFY_OK;
                }