]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virDomainNumatuneNodeSpecified: Fix const correctness
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 18 May 2023 08:27:36 +0000 (10:27 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 22 May 2023 11:49:34 +0000 (13:49 +0200)
The virDomainNumatuneNodeSpecified() function does not write into
passed @numatune pointer, it just reads from it. Therefore, the
argument should be const, which allows this function to be called
from places where virDomainNuma is already const (e.g. domain
validation code).

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/conf/numa_conf.c
src/conf/numa_conf.h

index be0c4572c552b0c48c96970bd8aa0deafa8ae961..dd4997c759bde7fac23471fd4311726fe002f723 100644 (file)
@@ -116,7 +116,7 @@ struct _virDomainNuma {
 
 
 bool
-virDomainNumatuneNodeSpecified(virDomainNuma *numatune,
+virDomainNumatuneNodeSpecified(const virDomainNuma *numatune,
                                int cellid)
 {
     if (numatune &&
index bbb928abb20bc7d36044fc48ab4b278d7802809e..f5a20315b64c00a898456fcd9fee2551a90e6307 100644 (file)
@@ -210,7 +210,7 @@ int virDomainNumatuneSpecifiedMaxNode(virDomainNuma *numatune);
 bool virDomainNumatuneNodesetIsAvailable(virDomainNuma *numatune,
                                          virBitmap *auto_nodeset);
 
-bool virDomainNumatuneNodeSpecified(virDomainNuma *numatune,
+bool virDomainNumatuneNodeSpecified(const virDomainNuma *numatune,
                                     int cellid);
 
 int virDomainNumaDefParseXML(virDomainNuma *def, xmlXPathContextPtr ctxt);