xfs: refactor attr3 leaf table size computation

Replace all the open-coded callsites with a single static inline helper.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>

diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
index c0d6252271378a31f8adf2af8d541b4eae8236aa..75d481427bfea40273f9322dfc1ecb5177e37dec 100644 (file)
--- a/fs/xfs/libxfs/xfs_attr_leaf.c
+++ b/fs/xfs/libxfs/xfs_attr_leaf.c
@@ -75,6 +75,16 @@ STATIC void xfs_attr3_leaf_moveents(struct xfs_da_args *args,
                        int move_count);
 STATIC int xfs_attr_leaf_entsize(xfs_attr_leafblock_t *leaf, int index);
 
+/* Compute the byte offset of the end of the leaf entry array. */
+static inline int
+xfs_attr_leaf_entries_end(
+       unsigned int                    hdrcount,
+       const struct xfs_attr_leafblock *leaf)
+{
+       return hdrcount * sizeof(struct xfs_attr_leaf_entry) +
+                       xfs_attr3_leaf_hdr_size(leaf);
+}
+
 /*
  * attr3 block 'firstused' conversion helpers.
  *
@@ -1409,8 +1419,7 @@ xfs_attr3_leaf_add(
         * Search through freemap for first-fit on new name length.
         * (may need to figure in size of entry struct too)
         */
-       tablesize = (ichdr.count + 1) * sizeof(xfs_attr_leaf_entry_t)
-                                       + xfs_attr3_leaf_hdr_size(leaf);
+       tablesize = xfs_attr_leaf_entries_end(ichdr.count + 1, leaf);
        for (sum = 0, i = XFS_ATTR_LEAF_MAPSIZE - 1; i >= 0; i--) {
                if (tablesize > ichdr.firstused) {
                        sum += ichdr.freemap[i].size;
@@ -1569,8 +1578,7 @@ xfs_attr3_leaf_add_work(
        if (be16_to_cpu(entry->nameidx) < ichdr->firstused)
                ichdr->firstused = be16_to_cpu(entry->nameidx);
 
-       new_end = ichdr->count * sizeof(struct xfs_attr_leaf_entry) +
-                                       xfs_attr3_leaf_hdr_size(leaf);
+       new_end = xfs_attr_leaf_entries_end(ichdr->count, leaf);
        old_end = new_end - sizeof(struct xfs_attr_leaf_entry);
 
        ASSERT(ichdr->firstused >= new_end);
@@ -1807,8 +1815,8 @@ xfs_attr3_leaf_rebalance(
                /*
                 * leaf2 is the destination, compact it if it looks tight.
                 */
-               max  = ichdr2.firstused - xfs_attr3_leaf_hdr_size(leaf1);
-               max -= ichdr2.count * sizeof(xfs_attr_leaf_entry_t);
+               max = ichdr2.firstused -
+                               xfs_attr_leaf_entries_end(ichdr2.count, leaf1);
                if (space > max)
                        xfs_attr3_leaf_compact(args, &ichdr2, blk2->bp);
 
@@ -1836,8 +1844,8 @@ xfs_attr3_leaf_rebalance(
                /*
                 * leaf1 is the destination, compact it if it looks tight.
                 */
-               max  = ichdr1.firstused - xfs_attr3_leaf_hdr_size(leaf1);
-               max -= ichdr1.count * sizeof(xfs_attr_leaf_entry_t);
+               max = ichdr1.firstused -
+                               xfs_attr_leaf_entries_end(ichdr1.count, leaf1);
                if (space > max)
                        xfs_attr3_leaf_compact(args, &ichdr1, blk1->bp);
 
@@ -2043,9 +2051,7 @@ xfs_attr3_leaf_toosmall(
        blk = &state->path.blk[ state->path.active-1 ];
        leaf = blk->bp->b_addr;
        xfs_attr3_leaf_hdr_from_disk(state->args->geo, &ichdr, leaf);
-       bytes = xfs_attr3_leaf_hdr_size(leaf) +
-               ichdr.count * sizeof(xfs_attr_leaf_entry_t) +
-               ichdr.usedbytes;
+       bytes = xfs_attr_leaf_entries_end(ichdr.count, leaf) + ichdr.usedbytes;
        if (bytes > (state->args->geo->blksize >> 1)) {
                *action = 0;    /* blk over 50%, don't try to join */
                return 0;
@@ -2103,9 +2109,8 @@ xfs_attr3_leaf_toosmall(
                bytes = state->args->geo->blksize -
                        (state->args->geo->blksize >> 2) -
                        ichdr.usedbytes - ichdr2.usedbytes -
-                       ((ichdr.count + ichdr2.count) *
-                                       sizeof(xfs_attr_leaf_entry_t)) -
-                       xfs_attr3_leaf_hdr_size(leaf);
+                       xfs_attr_leaf_entries_end(ichdr.count + ichdr2.count,
+                                       leaf);
 
                xfs_trans_brelse(state->args->trans, bp);
                if (bytes >= 0)
@@ -2167,8 +2172,7 @@ xfs_attr3_leaf_remove(
 
        ASSERT(ichdr.count > 0 && ichdr.count < args->geo->blksize / 8);
        ASSERT(args->index >= 0 && args->index < ichdr.count);
-       ASSERT(ichdr.firstused >= ichdr.count * sizeof(*entry) +
-                                       xfs_attr3_leaf_hdr_size(leaf));
+       ASSERT(ichdr.firstused >= xfs_attr_leaf_entries_end(ichdr.count, leaf));
 
        entry = &xfs_attr3_leaf_entryp(leaf)[args->index];
 
@@ -2181,8 +2185,7 @@ xfs_attr3_leaf_remove(
         *    find smallest free region in case we need to replace it,
         *    adjust any map that borders the entry table,
         */
-       tablesize = ichdr.count * sizeof(xfs_attr_leaf_entry_t)
-                                       + xfs_attr3_leaf_hdr_size(leaf);
+       tablesize = xfs_attr_leaf_entries_end(ichdr.count, leaf);
        tmp = ichdr.freemap[0].size;
        before = after = -1;
        smallest = XFS_ATTR_LEAF_MAPSIZE - 1;
@@ -2289,8 +2292,7 @@ xfs_attr3_leaf_remove(
         * Check if leaf is less than 50% full, caller may want to
         * "join" the leaf with a sibling if so.
         */
-       tmp = ichdr.usedbytes + xfs_attr3_leaf_hdr_size(leaf) +
-             ichdr.count * sizeof(xfs_attr_leaf_entry_t);
+       tmp = ichdr.usedbytes + xfs_attr_leaf_entries_end(ichdr.count, leaf);
 
        return tmp < args->geo->magicpct; /* leaf is < 37% full */
 }
@@ -2613,11 +2615,11 @@ xfs_attr3_leaf_moveents(
               ichdr_s->magic == XFS_ATTR3_LEAF_MAGIC);
        ASSERT(ichdr_s->magic == ichdr_d->magic);
        ASSERT(ichdr_s->count > 0 && ichdr_s->count < args->geo->blksize / 8);
-       ASSERT(ichdr_s->firstused >= (ichdr_s->count * sizeof(*entry_s))
-                                       + xfs_attr3_leaf_hdr_size(leaf_s));
+       ASSERT(ichdr_s->firstused >=
+                       xfs_attr_leaf_entries_end(ichdr_s->count, leaf_s));
        ASSERT(ichdr_d->count < args->geo->blksize / 8);
-       ASSERT(ichdr_d->firstused >= (ichdr_d->count * sizeof(*entry_d))
-                                       + xfs_attr3_leaf_hdr_size(leaf_d));
+       ASSERT(ichdr_d->firstused >=
+                       xfs_attr_leaf_entries_end(ichdr_d->count, leaf_d));
 
        ASSERT(start_s < ichdr_s->count);
        ASSERT(start_d <= ichdr_d->count);
@@ -2677,8 +2679,7 @@ xfs_attr3_leaf_moveents(
                        ichdr_d->usedbytes += tmp;
                        ichdr_s->count -= 1;
                        ichdr_d->count += 1;
-                       tmp = ichdr_d->count * sizeof(xfs_attr_leaf_entry_t)
-                                       + xfs_attr3_leaf_hdr_size(leaf_d);
+                       tmp = xfs_attr_leaf_entries_end(ichdr_d->count, leaf_d);
                        ASSERT(ichdr_d->firstused >= tmp);
 #ifdef GROT
                }
@@ -2714,8 +2715,8 @@ xfs_attr3_leaf_moveents(
        /*
         * Fill in the freemap information
         */
-       ichdr_d->freemap[0].base = xfs_attr3_leaf_hdr_size(leaf_d);
-       ichdr_d->freemap[0].base += ichdr_d->count * sizeof(xfs_attr_leaf_entry_t);
+       ichdr_d->freemap[0].base =
+               xfs_attr_leaf_entries_end(ichdr_d->count, leaf_d);
        ichdr_d->freemap[0].size = ichdr_d->firstused - ichdr_d->freemap[0].base;
        ichdr_d->freemap[1].base = 0;
        ichdr_d->freemap[2].base = 0;

diff --git a/fs/xfs/libxfs/xfs_da_format.h b/fs/xfs/libxfs/xfs_da_format.h
index 86de99e2f757071edccb4ff713fad3981b994ae2..7d55307e619fe9694ec2c9e379d06b692bf0c4f0 100644 (file)
--- a/fs/xfs/libxfs/xfs_da_format.h
+++ b/fs/xfs/libxfs/xfs_da_format.h
@@ -746,7 +746,7 @@ struct xfs_attr3_leafblock {
 #define        XFS_ATTR_LEAF_NAME_ALIGN        ((uint)sizeof(xfs_dablk_t))
 
 static inline int
-xfs_attr3_leaf_hdr_size(struct xfs_attr_leafblock *leafp)
+xfs_attr3_leaf_hdr_size(const struct xfs_attr_leafblock *leafp)
 {
        if (leafp->hdr.info.magic == cpu_to_be16(XFS_ATTR3_LEAF_MAGIC))
                return sizeof(struct xfs_attr3_leaf_hdr);