USB: usbip: drop redundant device reference

Driver core holds a reference to the USB device while it is bound to a
driver and there is no need to take additional references unless the
structure is needed after disconnect.

Drop the redundant device reference to reduce cargo culting, make it
easier to spot drivers where an extra reference is needed, and reduce
the risk of memory leaks when drivers fail to release it.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260305133851.2952-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/usbip/stub_dev.c b/drivers/usb/usbip/stub_dev.c
index 34990b7e2d189824ff1509e9b6ecda156ae86fcd..abfa11d6bde799489c99f5ea64273c5a3f9d476b 100644 (file)
--- a/drivers/usb/usbip/stub_dev.c
+++ b/drivers/usb/usbip/stub_dev.c
@@ -267,7 +267,7 @@ static struct stub_device *stub_device_alloc(struct usb_device *udev)
        if (!sdev)
                return NULL;
 
-       sdev->udev = usb_get_dev(udev);
+       sdev->udev = udev;
 
        /*
         * devid is defined with devnum when this driver is first allocated.
@@ -409,7 +409,6 @@ call_put_busid_priv:
        put_busid_priv(busid_priv);
 
 sdev_free:
-       usb_put_dev(udev);
        stub_device_free(sdev);
 
        return rc;
@@ -488,8 +487,6 @@ static void stub_disconnect(struct usb_device *udev)
        /* shutdown the current connection */
        shutdown_busid(busid_priv);
 
-       usb_put_dev(sdev->udev);
-
        /* we already have busid_priv, just lock busid_lock */
        spin_lock(&busid_priv->busid_lock);
        /* free sdev */