]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: dove: pmu: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Fri, 2 Jan 2026 12:48:02 +0000 (13:48 +0100)
committerGregory CLEMENT <gregory.clement@bootlin.com>
Mon, 5 Jan 2026 14:03:43 +0000 (15:03 +0100)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
drivers/soc/dove/pmu.c

index 7bbd3f940e4d982a1f3fdcc2bca97fa7654edbf6..dd8ade8e9ee860b8180d68df233f2a9a0ad2748d 100644 (file)
@@ -371,7 +371,7 @@ int __init dove_init_pmu_legacy(const struct dove_pmu_initdata *initdata)
  */
 int __init dove_init_pmu(void)
 {
-       struct device_node *np_pmu, *domains_node, *np;
+       struct device_node *np_pmu, *domains_node;
        struct pmu_data *pmu;
        int ret, parent_irq;
 
@@ -404,21 +404,18 @@ int __init dove_init_pmu(void)
 
        pmu_reset_init(pmu);
 
-       for_each_available_child_of_node(domains_node, np) {
+       for_each_available_child_of_node_scoped(domains_node, np) {
                struct of_phandle_args args;
                struct pmu_domain *domain;
 
                domain = kzalloc(sizeof(*domain), GFP_KERNEL);
-               if (!domain) {
-                       of_node_put(np);
+               if (!domain)
                        break;
-               }
 
                domain->pmu = pmu;
                domain->base.name = kasprintf(GFP_KERNEL, "%pOFn", np);
                if (!domain->base.name) {
                        kfree(domain);
-                       of_node_put(np);
                        break;
                }