]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
watchdog: sbsa: Update the W_IIDR Implementer bit mask to 0xFFF
authorNaina Mehta <naina.mehta@oss.qualcomm.com>
Fri, 21 Nov 2025 06:14:11 +0000 (11:44 +0530)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 18 Jan 2026 09:55:09 +0000 (10:55 +0100)
The implementer mask defined in the driver [1] captures bits 0-10,
whereas section C.4.2 of BSA specification [2] indicates that bits
0-11 of the W_IIDR register represent the implementer JEP106 code.
Update the SBSA_GWDT_IMPL_MASK corresponding to bits 0-11, while
at it update SBSA_GWDT_VERSION_MASK mask to use GENMASK.

[1] #define SBSA_GWDT_IMPL_MASK    0x7FF

[2] Implementer, bits [11:0]
Contains the JEP106 code of the company that implemented the
Generic Watchdog:
Bits[11:8] The JEP106 continuation code of the implementer.
Bit[7] Always 0
Bits [6:0] The JEP106 identity code of the implementer.

Signed-off-by: Naina Mehta <naina.mehta@oss.qualcomm.com>
Acked-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/sbsa_gwdt.c

index 6ce1bfb39064133c005bb48ccce8625ae1bc16c1..13933e12b754c0679a3ee34e27953be22d5bf6ae 100644 (file)
 #define SBSA_GWDT_WCS_WS0      BIT(1)
 #define SBSA_GWDT_WCS_WS1      BIT(2)
 
-#define SBSA_GWDT_VERSION_MASK  0xF
+#define SBSA_GWDT_VERSION_MASK  GENMASK(3, 0)
 #define SBSA_GWDT_VERSION_SHIFT 16
 
-#define SBSA_GWDT_IMPL_MASK    0x7FF
+#define SBSA_GWDT_IMPL_MASK    GENMASK(11, 0)
 #define SBSA_GWDT_IMPL_SHIFT   0
 #define SBSA_GWDT_IMPL_MEDIATEK        0x426