]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
ssl_lib.c: Check for NULL from SSL_CONNECTION_FROM_SSL()
authorAndrew Dinh <andrewd@openssl.org>
Wed, 19 Feb 2025 06:41:03 +0000 (13:41 +0700)
committerTomas Mraz <tomas@openssl.org>
Thu, 20 Feb 2025 14:30:25 +0000 (15:30 +0100)
Fixes https://scan5.scan.coverity.com/#/project-view/62507/10222?selectedIssue=1643027
Fixes https://scan5.scan.coverity.com/#/project-view/62507/10222?selectedIssue=1643028

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/26824)

ssl/ssl_lib.c

index 4307f020311acd3b71a6ea9f8310b7d8ca436661..f1c679083fb48e9f2b70c26b6b827b55bfc07380 100644 (file)
@@ -8226,6 +8226,9 @@ int SSL_set1_client_cert_type(SSL *s, const unsigned char *val, size_t len)
 {
     SSL_CONNECTION *sc = SSL_CONNECTION_FROM_SSL(s);
 
+    if (sc == NULL)
+        return 0;
+
     return set_cert_type(&sc->client_cert_type, &sc->client_cert_type_len,
                          val, len);
 }
@@ -8234,6 +8237,9 @@ int SSL_set1_server_cert_type(SSL *s, const unsigned char *val, size_t len)
 {
     SSL_CONNECTION *sc = SSL_CONNECTION_FROM_SSL(s);
 
+    if (sc == NULL)
+        return 0;
+
     return set_cert_type(&sc->server_cert_type, &sc->server_cert_type_len,
                          val, len);
 }