]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virdnsmasq: remove binaryPath argument from dnsmasqCapsNewFromBinary
authorPavel Hrdina <phrdina@redhat.com>
Wed, 14 Apr 2021 15:57:08 +0000 (17:57 +0200)
committerPavel Hrdina <phrdina@redhat.com>
Wed, 21 Apr 2021 12:18:31 +0000 (14:18 +0200)
We always pass DNSMASQ so there is no need for the argument at all.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/network/bridge_driver.c
src/util/virdnsmasq.c
src/util/virdnsmasq.h

index 706a557ee84edf79ff6e3263dad1dff49ef337e2..ee3f9dab0af646403651f86f22b1e7bac3451935 100644 (file)
@@ -130,7 +130,7 @@ networkDnsmasqCapsRefresh(virNetworkDriverState *driver)
 {
     dnsmasqCaps *caps;
 
-    if (!(caps = dnsmasqCapsNewFromBinary(DNSMASQ)))
+    if (!(caps = dnsmasqCapsNewFromBinary()))
         return -1;
 
     networkDriverLock(driver);
@@ -749,7 +749,7 @@ networkStateInitialize(bool privileged,
         goto error;
 
     /* if this fails now, it will be retried later with networkDnsmasqCapsRefresh() */
-    network_driver->dnsmasqCaps = dnsmasqCapsNewFromBinary(DNSMASQ);
+    network_driver->dnsmasqCaps = dnsmasqCapsNewFromBinary();
 
     if (!(network_driver->networks = virNetworkObjListNew()))
         goto error;
index 82a26e83e986045c0e2a5498b9cd66b7fa364d42..f2f606913fdf549a4667e3a65582269805ec9144 100644 (file)
@@ -759,9 +759,9 @@ dnsmasqCapsNewFromBuffer(const char *buf)
 }
 
 dnsmasqCaps *
-dnsmasqCapsNewFromBinary(const char *binaryPath)
+dnsmasqCapsNewFromBinary(void)
 {
-    dnsmasqCaps *caps = dnsmasqCapsNewEmpty(binaryPath);
+    dnsmasqCaps *caps = dnsmasqCapsNewEmpty(DNSMASQ);
 
     if (!caps)
         return NULL;
index cf6d50fe38f05fb1b927c8d1bff664363fe096a9..ee9839cd250a0be66437264bc59119d8f070e402 100644 (file)
@@ -100,7 +100,7 @@ int              dnsmasqDelete(const dnsmasqContext *ctx);
 int              dnsmasqReload(pid_t pid);
 
 dnsmasqCaps *dnsmasqCapsNewFromBuffer(const char *buf);
-dnsmasqCaps *dnsmasqCapsNewFromBinary(const char *binaryPath);
+dnsmasqCaps *dnsmasqCapsNewFromBinary(void);
 bool dnsmasqCapsGet(dnsmasqCaps *caps, dnsmasqCapsFlags flag);
 const char *dnsmasqCapsGetBinaryPath(dnsmasqCaps *caps);
 unsigned long dnsmasqCapsGetVersion(dnsmasqCaps *caps);