app_queue: Add LoginTime field for member in a queue.

Add a time_t logintime to storage a time when a member is added into a
queue.

Also, includes show this time (in seconds) using a 'queue show' command
and the field LoginTime for response for AMI events.

ASTERISK-18069 #close

Change-Id: Ied6c3a300f78d78eebedeb3e16a1520fc3fff190

diff --git a/apps/app_queue.c b/apps/app_queue.c
index 3c4cdbc012f4b14c69361c8aef3d741689c8bdeb..cfe49c30c945d03d9e8b9a1ae99d9717c44bdf6c 100644 (file)
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -1080,6 +1080,9 @@
                                <parameter name="LastPause">
                                        <para>The time when started last paused the queue member.</para>
                                </parameter>
+                               <parameter name="LoginTime">
+                                       <para>The time this member logged in to the queue, expressed in seconds since 00:00, Jan 1, 1970 UTC.</para>
+                               </parameter>
                                <parameter name="InCall">
                                        <para>Set to 1 if member is in call. Set to 0 after LastCall time is updated.</para>
                                        <enumlist>
@@ -1615,6 +1618,7 @@ struct member {
        time_t starttime;                    /*!< The time at which the member answered the current caller. */
        time_t lastcall;                     /*!< When last successful call was hungup */
        time_t lastpause;                    /*!< When started the last pause */
+       time_t logintime;                    /*!< The time when started the login */
        struct call_queue *lastqueue;        /*!< Last queue we received a call */
        unsigned int dead:1;                 /*!< Used to detect members deleted in realtime */
        unsigned int delme:1;                /*!< Flag to delete entry on reload */
@@ -2263,7 +2267,7 @@ static void queue_publish_member_blob(struct stasis_message_type *type, struct a
 
 static struct ast_json *queue_member_blob_create(struct call_queue *q, struct member *mem)
 {
-       return ast_json_pack("{s: s, s: s, s: s, s: s, s: s, s: i, s: i, s: i, s: i, s: i, s: i, s: i, s: s, s: i, s: i}",
+       return ast_json_pack("{s: s, s: s, s: s, s: s, s: s, s: i, s: i, s: i, s: i, s: i, s: i, s: i, s: i, s: s, s: i, s: i}",
                "Queue", q->name,
                "MemberName", mem->membername,
                "Interface", mem->interface,
@@ -2273,6 +2277,7 @@ static struct ast_json *queue_member_blob_create(struct call_queue *q, struct me
                "CallsTaken", mem->calls,
                "LastCall", (int)mem->lastcall,
                "LastPause", (int)mem->lastpause,
+               "LoginTime", (int)mem->logintime,
                "InCall", mem->starttime ? 1 : 0,
                "Status", mem->status,
                "Paused", mem->paused,
@@ -2746,6 +2751,7 @@ static struct member *create_queue_member(const char *interface, const char *mem
                if (paused) {
                        time(&cur->lastpause); /* Update time of last pause */
                }
+               time(&cur->logintime);
                ast_copy_string(cur->interface, interface, sizeof(cur->interface));
                if (!ast_strlen_zero(state_interface)) {
                        ast_copy_string(cur->state_interface, state_interface, sizeof(cur->state_interface));
@@ -9784,6 +9790,10 @@ static void print_queue(struct mansession *s, int fd, struct call_queue *q)
                        } else {
                                ast_str_append(&out, 0, " has taken no calls yet");
                        }
+                       ast_str_append(&out, 0, " %s(login was %ld secs ago)%s",
+                               ast_term_color(COLOR_BROWN, COLOR_BLACK),
+                               (long) (now - mem->logintime),
+                               ast_term_reset());
                        do_print(s, fd, ast_str_buffer(out));
                        ao2_ref(mem, -1);
                }
@@ -10226,6 +10236,7 @@ static int manager_queues_status(struct mansession *s, const struct message *m)
                                                "CallsTaken: %d\r\n"
                                                "LastCall: %d\r\n"
                                                "LastPause: %d\r\n"
+                                               "LoginTime: %d\r\n"
                                                "InCall: %d\r\n"
                                                "Status: %d\r\n"
                                                "Paused: %d\r\n"
@@ -10234,7 +10245,7 @@ static int manager_queues_status(struct mansession *s, const struct message *m)
                                                "%s"
                                                "\r\n",
                                                q->name, mem->membername, mem->interface, mem->state_interface, mem->dynamic ? "dynamic" : "static",
-                                               mem->penalty, mem->calls, (int)mem->lastcall, (int)mem->lastpause, mem->starttime ? 1 : 0, mem->status,
+                                               mem->penalty, mem->calls, (int)mem->lastcall, (int)mem->lastpause, (int)mem->logintime, mem->starttime ? 1 : 0, mem->status,
                                                mem->paused, mem->reason_paused, mem->wrapuptime, idText);
                                        ++q_items;
                                }

diff --git a/doc/CHANGES-staging/app_queue_logintime.txt b/doc/CHANGES-staging/app_queue_logintime.txt
new file mode 100644 (file)
index 0000000..5b0eea4
--- /dev/null
+++ b/doc/CHANGES-staging/app_queue_logintime.txt
@@ -0,0 +1,9 @@
+Subject: app_queue
+
+Add field to save the time value when a member enter a queue.
+Shows this time in seconds using 'queue show' command and the
+field LoginTime for responses for AMI the events.
+
+The output for the CLI command `queue show` is changed by added a
+extra data field for the information of the time login time for each
+member.