]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-ssl-iostream: test-iostream-ssl - Avoid ssl_iostream_settings_dup()
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Fri, 16 Jun 2023 12:20:23 +0000 (15:20 +0300)
committerAki Tuomi <aki.tuomi@open-xchange.com>
Wed, 12 Feb 2025 10:34:09 +0000 (12:34 +0200)
This is the only place still using the function, and it's not really
necessary.

src/lib-ssl-iostream/test-iostream-ssl.c

index 75e321dbb2d93af39ef3c5b722df82d3ee091035..ed6893accb4371312ed456ceb78ab4386f829c60 100644 (file)
@@ -158,7 +158,8 @@ create_test_endpoint(int fd, const struct ssl_iostream_settings *set)
        ep->input = i_stream_create_fd(ep->fd, 512);
        ep->output = o_stream_create_fd(ep->fd, 1024);
        o_stream_uncork(ep->output);
-       ep->set = ssl_iostream_settings_dup(pool, set);
+       /* We assume here that strings continue to be valid pointers */
+       ep->set = p_memdup(pool, set, sizeof(*set));
        ep->last_write = buffer_create_dynamic(pool, 1024);
        return ep;
 }