]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm64: dts: exynos: gs101: remove syscon compatible from pmu node
authorPeter Griffin <peter.griffin@linaro.org>
Fri, 14 Nov 2025 12:00:17 +0000 (12:00 +0000)
committerKrzysztof Kozlowski <krzk@kernel.org>
Tue, 16 Dec 2025 07:01:47 +0000 (08:01 +0100)
Since commit ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a
"syscon" compatible") it is possible to register a regmap without the
syscon compatible in the node.

As mentioned in that commit, it's not correct to claim we are compatible
with syscon, as a MMIO regmap created by syscon won't work. Removing the
syscon compatible means syscon driver won't ever create a mmio regmap.

Note this isn't usually an issue today as exynos-pmu runs at an early
initcall so the custom regmap will have been registered first. However
changes proposed in [1] will bring -EPROBE_DEFER support to syscon allowing
this mechanism to be more robust, especially in highly modularized systems.

Technically this is a ABI break but no other platforms are
affected. Additionally (with the benefit of hindsight) a MMIO syscon has
never worked for PMU register writes, thus the ABI break is justified.

Link: https://lore.kernel.org/lkml/aQdHmrchkmOr34r3@stanley.mountain/
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://patch.msgid.link/20251114-remove-pmu-syscon-compat-v2-2-9496e8c496c7@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
arch/arm64/boot/dts/exynos/google/gs101.dtsi

index 380f7e70910ab8bcc28690782532fff87ca7e30b..9b38c2248016aa65293c0abf9ccaf20857d89693 100644 (file)
                };
 
                pmu_system_controller: system-controller@17460000 {
-                       compatible = "google,gs101-pmu", "syscon";
+                       compatible = "google,gs101-pmu";
                        reg = <0x17460000 0x10000>;
                        google,pmu-intr-gen-syscon = <&pmu_intr_gen>;