Fix a crash when accessing hidden services: it would work the first

time you use a given introduction point for your service, but
on subsequent requests we'd be using garbage memory. Fixed by
Karsten Loesing. Bugfix on 0.2.0.12-alpha.

svn:r12913

diff --git a/ChangeLog b/ChangeLog
index f1716118b407f18e4eb7d045e3c3f77386df4a2c..b5c07e03902299c93b28734ad33f5e4ff6ea1d89 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -4,6 +4,10 @@ Changes in version 0.2.0.14-alpha - 2007-12-??
       unexpected (it used to be in our networkstatus when we started
       fetching it, but it isn't in our current networkstatus), and we
       aren't using bridges. Bugfix on 0.2.0.x.
+    - Fix a crash when accessing hidden services: it would work the first
+      time you use a given introduction point for your service, but
+      on subsequent requests we'd be using garbage memory. Fixed by
+      Karsten Loesing. Bugfix on 0.2.0.12-alpha.
 
   o Minor bugfixes:
     - Make the unit tests build again.

diff --git a/src/or/rendclient.c b/src/or/rendclient.c
index 8401873346fb4170defba344a80002faef816ab0..3c5f75552c09a08fdd4e69974042be9a774a65e3 100644 (file)
--- a/src/or/rendclient.c
+++ b/src/or/rendclient.c
@@ -549,7 +549,6 @@ rend_client_get_random_intro(const char *query)
       goto again;
     }
     extend_info_free(intro->extend_info);
-    intro = tor_malloc_zero(sizeof(rend_intro_point_t));
     intro->extend_info = extend_info_from_router(router);
   }
   return extend_info_dup(intro->extend_info);