]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
domain_conf: make virDomainIOMMUDefFormat() void
authorMatt Coleman <mcoleman@datto.com>
Fri, 6 Nov 2020 03:32:51 +0000 (22:32 -0500)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 11 Nov 2020 11:53:11 +0000 (12:53 +0100)
This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/domain_conf.c

index 3d3e524ec75014a052adcf2c00418a1a1eb83a29..4cea54761fcbe86c9c6c6dbe8039beff5148eb14 100644 (file)
@@ -29372,7 +29372,7 @@ virDomainDefIothreadShouldFormat(virDomainDefPtr def)
 }
 
 
-static int
+static void
 virDomainIOMMUDefFormat(virBufferPtr buf,
                         const virDomainIOMMUDef *iommu)
 {
@@ -29407,8 +29407,6 @@ virDomainIOMMUDefFormat(virBufferPtr buf,
                       virDomainIOMMUModelTypeToString(iommu->model));
 
     virXMLFormatElement(buf, "iommu", &attrBuf, &childBuf);
-
-    return 0;
 }
 
 
@@ -30384,9 +30382,8 @@ virDomainDefFormatInternalSetRootName(virDomainDefPtr def,
             return -1;
     }
 
-    if (def->iommu &&
-        virDomainIOMMUDefFormat(buf, def->iommu) < 0)
-        return -1;
+    if (def->iommu)
+        virDomainIOMMUDefFormat(buf, def->iommu);
 
     if (def->vsock &&
         virDomainVsockDefFormat(buf, def->vsock) < 0)