The secret driver is stateful, link it directly to libvirtd

All other stateful drivers are linked directly to libvirtd
instead of libvirt.so. Link the secret driver to libvirtd too.

* daemon/Makefile.am: link the secret driver to libvirtd
* daemon/libvirtd.c: add #ifdef WITH_SECRETS blocks
* src/Makefile.am: don't link the secret driver to libvirt.so
* src/libvirt_private.syms: remove the secretRegister symbol

diff --git a/daemon/Makefile.am b/daemon/Makefile.am
index ab3f238b160a06c89bf3f49eb19996d6a0f1af4f..958a4f600d6a3b3089ee6f23c7b8695bb4afa5de 100644 (file)
--- a/daemon/Makefile.am
+++ b/daemon/Makefile.am
@@ -110,6 +110,10 @@ endif
 if WITH_NODE_DEVICES
     libvirtd_LDADD += ../src/libvirt_driver_nodedev.la
 endif
+
+if WITH_SECRETS
+    libvirtd_LDADD += ../src/libvirt_driver_secret.la
+endif
 endif
 
 libvirtd_LDADD += ../src/libvirt.la

diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 281a46a31e317a26bb6546a08cc9bb8fecd926aa..c53ef0a354db193bb7df6411cabd6c561270b7b3 100644 (file)
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -93,8 +93,10 @@
 #ifdef WITH_NODE_DEVICES
 #include "node_device/node_device_driver.h"
 #endif
+#ifdef WITH_SECRETS
 #include "secret/secret_driver.h"
 #endif
+#endif
 
 
 #ifdef __sun
@@ -880,7 +882,9 @@ static struct qemud_server *qemudInitialize(void) {
 #if defined(WITH_NODE_DEVICES)
     nodedevRegister();
 #endif
+#ifdef WITH_SECRETS
     secretRegister();
+#endif
 #ifdef WITH_QEMU
     qemuRegister();
 #endif

diff --git a/src/Makefile.am b/src/Makefile.am
index 51a40b6c615ab9ab28cf97ba6132f3743e1f1b5d..8ef0e818802c86264259975bcd2c6f85fdda55da 100644 (file)
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -598,7 +598,8 @@ if WITH_DRIVER_MODULES
 mod_LTLIBRARIES += libvirt_driver_secret.la
 else
 noinst_LTLIBRARIES += libvirt_driver_secret.la
-libvirt_la_LIBADD += libvirt_driver_secret.la
+# Stateful, so linked to daemon instead
+#libvirt_la_LIBADD += libvirt_driver_secret.la
 endif
 libvirt_driver_secret_la_CFLAGS = \
                -I@top_srcdir@/src/conf

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index cfcef44e2d780ea5228e31fd44701de48724380a..10940ebab3986a87cfb6819c9fd5594f2e6381a9 100644 (file)
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -453,8 +453,6 @@ virSecretDefParseString;
 virSecretDefParseFile;
 virSecretDefFormat;
 
-# secret_driver.h
-secretRegister;
 
 # security.h
 virSecurityDriverVerify;