mfd: dln2: Switch to managed resources and fix bare unsigned types

Convert dln2_probe and dln2_setup_rx_urbs to use devm_kzalloc() and
devm_kmalloc() respectively. This simplifies resource management by
allowing the removal of manual kfree() calls in dln2_free() and
dln2_free_rx_urbs().

Additionally, update bare 'unsigned' types to 'unsigned int' to satisfy
checkpatch.pl warnings and comply with the Linux kernel coding style.

Signed-off-by: Subhash Rawat <rawatsubhash02@gmail.com>
Link: https://patch.msgid.link/20260303183236.574940-1-rawatsubhash02@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c
index c810b83ac955dad47080e8b428b3794d73eae5f4..0b1e7fd7f5d734a4ece8e44d92bcfa2349549e4a 100644 (file)
--- a/drivers/mfd/dln2.c
+++ b/drivers/mfd/dln2.c
@@ -424,8 +424,8 @@ static void free_rx_slot(struct dln2_dev *dln2, u16 handle, int slot)
 }
 
 static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,
-                         const void *obuf, unsigned obuf_len,
-                         void *ibuf, unsigned *ibuf_len)
+                         const void *obuf, unsigned int obuf_len,
+                         void *ibuf, unsigned int *ibuf_len)
 {
        int ret = 0;
        int rx_slot;
@@ -511,8 +511,8 @@ out_decr:
 }
 
 int dln2_transfer(struct platform_device *pdev, u16 cmd,
-                 const void *obuf, unsigned obuf_len,
-                 void *ibuf, unsigned *ibuf_len)
+                 const void *obuf, unsigned int obuf_len,
+                 void *ibuf, unsigned int *ibuf_len)
 {
        struct dln2_platform_data *dln2_pdata;
        struct dln2_dev *dln2;
@@ -583,10 +583,8 @@ static void dln2_free_rx_urbs(struct dln2_dev *dln2)
 {
        int i;
 
-       for (i = 0; i < DLN2_MAX_URBS; i++) {
+       for (i = 0; i < DLN2_MAX_URBS; i++)
                usb_free_urb(dln2->rx_urb[i]);
-               kfree(dln2->rx_buf[i]);
-       }
 }
 
 static void dln2_stop_rx_urbs(struct dln2_dev *dln2)
@@ -600,7 +598,6 @@ static void dln2_stop_rx_urbs(struct dln2_dev *dln2)
 static void dln2_free(struct dln2_dev *dln2)
 {
        dln2_free_rx_urbs(dln2);
-       kfree(dln2);
 }
 
 static int dln2_setup_rx_urbs(struct dln2_dev *dln2,
@@ -608,9 +605,10 @@ static int dln2_setup_rx_urbs(struct dln2_dev *dln2,
 {
        int i;
        const int rx_max_size = DLN2_RX_BUF_SIZE;
+       struct device *dev = &dln2->interface->dev;
 
        for (i = 0; i < DLN2_MAX_URBS; i++) {
-               dln2->rx_buf[i] = kmalloc(rx_max_size, GFP_KERNEL);
+               dln2->rx_buf[i] = devm_kmalloc(dev, rx_max_size, GFP_KERNEL);
                if (!dln2->rx_buf[i])
                        return -ENOMEM;
 
@@ -777,7 +775,7 @@ static int dln2_probe(struct usb_interface *interface,
        if (ret)
                return ret;
 
-       dln2 = kzalloc_obj(*dln2);
+       dln2 = devm_kzalloc(dev, sizeof(*dln2), GFP_KERNEL);
        if (!dln2)
                return -ENOMEM;