]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
segfault in imsm create with wrong arguments
authorLuca Berra <bluca@comedia.it>
Sun, 12 Dec 2010 10:33:55 +0000 (11:33 +0100)
committerNeilBrown <neilb@suse.de>
Mon, 13 Dec 2010 02:51:07 +0000 (13:51 +1100)
When calling mdadm -C --metadata=imsm -l 1 /dev/sd..
mdadm segfaults in default_chunk_imsm()
above syntax is incorrect, but mdadm should error instead of segfaulting

Signed-off-by: Luca Berra <bluca@comedia.it>
Signed-off-by: NeilBrown <neilb@suse.de>
super-intel.c

index b880a74c4b16f8890c0edfb6ad54289274fe518e..b3a116f90308d75f2229c6ba1b70a3e78a7a1ce0 100644 (file)
@@ -4119,7 +4119,7 @@ static int default_chunk_imsm(struct supertype *st)
 {
        struct intel_super *super = st->sb;
 
-       if (!super->orom)
+       if (!super || !super->orom)
                return 0;
 
        return imsm_orom_default_chunk(super->orom);