]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
syslinux: Disable error on implicit-function-declaration
authorKhem Raj <raj.khem@gmail.com>
Fri, 2 Feb 2024 08:19:08 +0000 (00:19 -0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 5 Feb 2024 14:03:18 +0000 (14:03 +0000)
syslinux has vendored copy of ext2fs/ext2_fs.h but uses ext2fs/ext2fs.h
from e2fsprogs package, however, ext2fs/ext2fs.h has dependencies on
ext2fs/ext2_fs.h coming from e2fsprogs package as these both headers
come from same package, here syslinux uses ext2fs.h from e2fsprogs but
supplies its own copy of ext2_fs.h which maybe out of sync and that
results in warnings about implicit implicit-function-declarations
e.g.

recipe-sysroot/usr/include/ext2fs/ext2fs.h:727:16: error: implicit declaration of function 'ext2fs_has_feature_gdt_csum' [-Wimplicit-function-declaration]
|   727 |                ext2fs_has_feature_gdt_csum(fs->super);
|       |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~

ext2fs_has_feature_gdt_csum here comes from newer version of
ext2fs/ext2_fs.h but missing from vendored copy, hence the warning.

With gcc-14 this warning is treated as error by default, which breaks
the build, so lets treat it as warning only.

All these functions are never used in syslinux, so functionality-wise we
are fine.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb

index 332655bdf9823bc456a5d792fb04e5dbd436aafb..c8e7f25d2b0031db1f2e682f9c8fdef8169bd21a 100644 (file)
@@ -48,7 +48,7 @@ TARGET_LDFLAGS = ""
 SECURITY_LDFLAGS = ""
 LDFLAGS_SECTION_REMOVAL = ""
 
-CFLAGS:append = " -DNO_INLINE_FUNCS"
+CFLAGS:append = " -DNO_INLINE_FUNCS -Wno-error=implicit-function-declaration"
 
 EXTRA_OEMAKE = " \
        BINDIR=${bindir} SBINDIR=${sbindir} LIBDIR=${libdir} \