tc: q_ets: drop dead code from argument parsing

Checking for nbands to be at least 1 at this point is useless. Indeed:
- ets requires "bands", "quanta" or "strict" to be specified
- if "bands" is specified, nbands cannot be negative, see parse_nbands()
- if "strict" is specified, nstrict cannot be negative, see
  parse_nbands()
- if "quantum" is specified, nquanta cannot be negative, see
  parse_quantum()
- if "bands" is not specified, nbands is set to nstrict+nquanta
- the previous if statement takes care of the case when none of them are
  specified and nbands is 0, terminating execution.

Thus nbands cannot be < 1 at this point and this code cannot be executed.

Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
Signed-off-by: David Ahern <dsahern@kernel.org>

diff --git a/tc/q_ets.c b/tc/q_ets.c
index e7903d50e50f3986cffa865a1e2e4b9c9b0612de..7380bb2f08b06b4db864e816c4b6b340f068fe34 100644 (file)
--- a/tc/q_ets.c
+++ b/tc/q_ets.c
@@ -147,11 +147,6 @@ parse_priomap:
                explain();
                return -1;
        }
-       if (nbands < 1) {
-               fprintf(stderr, "The number of \"bands\" must be >= 1\n");
-               explain();
-               return -1;
-       }
        if (nstrict + nquanta > nbands) {
                fprintf(stderr, "Not enough total bands to cover all the strict bands and quanta\n");
                explain();