]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
Fix "White space before end tags can break the config parser"
authorjanjust <janjust@nikhef.nl>
Sat, 10 Oct 2015 16:12:49 +0000 (18:12 +0200)
committerGert Doering <gert@greenie.muc.de>
Sun, 11 Oct 2015 07:58:11 +0000 (09:58 +0200)
trac #569

Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <1444493569-24026-1-git-send-email-janjust@nikhef.nl>
URL: http://article.gmane.org/gmane.network.openvpn.devel/10249

Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit c67acea173dc9ee37220f5b9ff14ede081181992)

src/openvpn/options.c

index 019ae6cb2c4bd619d2fa05edad22eaaf7399a392..fc420bfffa3585a926741afedf1c5dffa2073777 100644 (file)
@@ -3756,13 +3756,16 @@ static char *
 read_inline_file (struct in_src *is, const char *close_tag, struct gc_arena *gc)
 {
   char line[OPTION_LINE_SIZE];
+  char *line_ptr = line;
   struct buffer buf = alloc_buf (8*OPTION_LINE_SIZE);
   char *ret;
   bool endtagfound = false;
 
   while (in_src_get (is, line, sizeof (line)))
     {
-      if (!strncmp (line, close_tag, strlen (close_tag)))
+      /* Remove leading spaces */
+      while (isspace(*line_ptr)) line_ptr++;
+      if (!strncmp (line_ptr, close_tag, strlen (close_tag)))
        {
          endtagfound = true;
          break;