]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: airoha: an7583: fix incorrect led mapping in phy4_led1 pin function
authorMikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Sat, 6 Jun 2026 02:03:37 +0000 (05:03 +0300)
committerLinus Walleij <linusw@kernel.org>
Thu, 11 Jun 2026 11:52:47 +0000 (13:52 +0200)
phy4_led1 pin function maps led incorrectly. It uses the same map as
phy3_led1. PHY{X} should map to LAN{N}_PHY_LED_MAP(X-1).

Fixes: 3ffeb17a9a27 ("pinctrl: airoha: add support for Airoha AN7583 PINs")
Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>
drivers/pinctrl/airoha/pinctrl-airoha.c

index bdfeea390998968d3d7642c23458005b6503be3e..4b83aa64b49de3e6f6c3fe4c69a92192f5b89862 100644 (file)
@@ -1710,13 +1710,13 @@ static const struct airoha_pinctrl_func_group an7583_phy3_led1_func_group[] = {
 
 static const struct airoha_pinctrl_func_group an7583_phy4_led1_func_group[] = {
        AIROHA_PINCTRL_PHY_LED1("gpio8", GPIO_LAN0_LED1_MODE_MASK,
-                               LAN0_LED_MAPPING_MASK, LAN0_PHY_LED_MAP(2)),
+                               LAN0_LED_MAPPING_MASK, LAN0_PHY_LED_MAP(3)),
        AIROHA_PINCTRL_PHY_LED1("gpio9", GPIO_LAN1_LED1_MODE_MASK,
-                               LAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(2)),
+                               LAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(3)),
        AIROHA_PINCTRL_PHY_LED1("gpio10", GPIO_LAN2_LED1_MODE_MASK,
-                               LAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(2)),
+                               LAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(3)),
        AIROHA_PINCTRL_PHY_LED1("gpio11", GPIO_LAN3_LED1_MODE_MASK,
-                               LAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(2)),
+                               LAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(3)),
 };
 
 static const struct airoha_pinctrl_func en7581_pinctrl_funcs[] = {