]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
irqchip/aslint-sswi: Fix error check of of_io_request_and_map() result
authorVladimir Kondratiev <vladimir.kondratiev@mobileye.com>
Sun, 18 Jan 2026 08:28:43 +0000 (10:28 +0200)
committerThomas Gleixner <tglx@kernel.org>
Sun, 18 Jan 2026 13:39:18 +0000 (14:39 +0100)
of_io_request_and_map() returns IOMEM_ERR_PTR() on failure which is
non-NULL.

Fixes: 8a7f030df897 ("irqchip/aslint-sswi: Request IO memory resource")
Reported-by: Chris Mason <clm@meta.com>
Signed-off-by: Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260118082843.2786630-1-vladimir.kondratiev@mobileye.com
Closes: https://lore.kernel.org/all/20260116124257.78357-1-clm@meta.com
drivers/irqchip/irq-aclint-sswi.c

index 325501f34a9bc95892a5b06725b8216c86d8b610..ca06efd86fa1a767a6fd1601df503d5bb24a3d4e 100644 (file)
@@ -110,8 +110,10 @@ static int __init aclint_sswi_probe(struct fwnode_handle *fwnode)
                return -EINVAL;
 
        reg = of_io_request_and_map(to_of_node(fwnode), 0, NULL);
-       if (!reg)
-               return -ENOMEM;
+       if (IS_ERR(reg)) {
+               pr_err("%pfwP: Failed to map MMIO region\n", fwnode);
+               return PTR_ERR(reg);
+       }
 
        /* Parse SSWI setting */
        rc = aclint_sswi_parse_irq(fwnode, reg);