output/json: Close jb object on error

Issue: 7194

Ensure that the jb object is closed on errors.

diff --git a/src/output-json.c b/src/output-json.c
index 7c3b7e27579cc9c4852e0e594b17a9c824629f43..6e5ff238d7a586c312d27a24d75373a5f2c5a7a0 100644 (file)
--- a/src/output-json.c
+++ b/src/output-json.c
@@ -445,7 +445,13 @@ void EvePacket(const Packet *p, JsonBuilder *js, unsigned long max_length)
     if (!jb_open_object(js, "packet_info")) {
         return;
     }
+    /*
+     * ensure the object is closed on error. This is done defensively
+     * in case additional logic is added before the final jb_close()
+     * invocation
+     */
     if (!jb_set_uint(js, "linktype", p->datalink)) {
+        jb_close(js);
         return;
     }
     jb_close(js);