missing_lock, not missing_unlock (CID #1414431) (#4635)

Typo in coverity annotation. Unnecessary missing_lock annotations
have been removed.

diff --git a/src/lib/server/exfile.c b/src/lib/server/exfile.c
index 4323f4741ad20e98516fcbd565d40c34e1ba42fd..2ff0f0677046254aeaff6c89fb554526b62d277f 100644 (file)
--- a/src/lib/server/exfile.c
+++ b/src/lib/server/exfile.c
@@ -508,7 +508,6 @@ try_lock:
 
        exfile_trigger_exec(ef, &ef->entries[i], "reserve");
 
-       /* coverity[missing_unlock] */
        return ef->entries[i].fd;
 }
 

diff --git a/src/lib/server/pool.c b/src/lib/server/pool.c
index 2269c9603c585bed06833bf50ebe1a4d024022f3..c7161f287750e02cc92bda784b747e9d71d6c1dd 100644 (file)
--- a/src/lib/server/pool.c
+++ b/src/lib/server/pool.c
@@ -295,7 +295,6 @@ static fr_pool_connection_t *connection_find(fr_pool_t *pool, void *conn)
 #endif
 
                        fr_assert(this->in_use == true);
-                       /* coverity[missing_unlock] */
                        return this;
                }
        }
@@ -518,7 +517,6 @@ static fr_pool_connection_t *connection_spawn(fr_pool_t *pool, request_t *reques
        pthread_cond_broadcast(&pool->done_spawn);
        if (unlock) pthread_mutex_unlock(&pool->mutex);
 
-       /* coverity[missing_unlock] */
        return this;
 }
 
@@ -1051,7 +1049,7 @@ fr_pool_t *fr_pool_init(TALLOC_CTX *ctx,
                goto error;
        }
 
-       /* coverity[missing_unlock] */
+       /* coverity[missing_lock] */
        pool->pending_window = (pool->max_pending > 0) ? pool->max_pending : pool->max;
 
        if (pool->min > pool->max) {

diff --git a/src/modules/rlm_detail/rlm_detail.c b/src/modules/rlm_detail/rlm_detail.c
index 233e1e18a4db4c2fc99dbf727f483be9cdb52dcc..3b93a97051e467d8d224fcdc584d4674c43b7994 100644 (file)
--- a/src/modules/rlm_detail/rlm_detail.c
+++ b/src/modules/rlm_detail/rlm_detail.c
@@ -379,7 +379,6 @@ static unlang_action_t CC_HINT(nonnull) detail_do(rlm_rcode_t *p_result, module_
        outfd = exfile_open(inst->ef, buffer, inst->perm);
        if (outfd < 0) {
                RPERROR("Couldn't open file %s", buffer);
-               /* coverity[missing_unlock] */
                RETURN_MODULE_FAIL;
        }
 

diff --git a/src/modules/rlm_linelog/rlm_linelog.c b/src/modules/rlm_linelog/rlm_linelog.c
index 9434ae3096a115b2f36c7cc68ddbe7fdebd8ad87..5861791f24e55993e8ec74198a58bf56f10f7af8 100644 (file)
--- a/src/modules/rlm_linelog/rlm_linelog.c
+++ b/src/modules/rlm_linelog/rlm_linelog.c
@@ -782,7 +782,6 @@ finish:
        talloc_free(vpt);
        talloc_free(vector);
 
-       /* coverity[missing_unlock] */
        RETURN_MODULE_RCODE(rcode);
 }
 

diff --git a/src/modules/rlm_sql/sql.c b/src/modules/rlm_sql/sql.c
index 43309a4eb60df1174830bae0d97e9bcc5d0bf1cb..db6777db8c24f0ae35b9c513dda6c5b288212f23 100644 (file)
--- a/src/modules/rlm_sql/sql.c
+++ b/src/modules/rlm_sql/sql.c
@@ -612,7 +612,6 @@ void rlm_sql_query_log(rlm_sql_t const *inst, request_t *request, sql_acct_secti
                ERROR("Couldn't open logfile '%s': %s", expanded, fr_syserror(errno));
 
                talloc_free(expanded);
-               /* coverity[missing_unlock] */
                return;
        }