]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: rt700: don't set dapm->bias_level
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tue, 8 Jul 2025 02:46:42 +0000 (02:46 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 8 Jul 2025 08:49:52 +0000 (09:49 +0100)
snd_soc_component_set_bias_level() (A) which will call .set_bias_level()
callback (B) will be called from snd_soc_dapm_force_bias_level() (C) only,
and it sets dapm->bias_level (D) inside. No need to set it by each driver.
Remove it.

(A) int snd_soc_component_set_bias_level(...)
{
...
if (component->driver->set_bias_level)
(B) ret = component->driver->set_bias_level(...);
...
}

(C) int snd_soc_dapm_force_bias_level(...)
{
...
if (dapm->component)
(A) ret = snd_soc_component_set_bias_level(...);

if (ret == 0)
(D) dapm->bias_level = level;
...
}

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://patch.msgid.link/87qzyrmmb2.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt700.c

index 434b926f96c8376c1c5b8b73c37b01b2d64641fe..f817209316c25c19efffc4b9f58b5348cccbeaf9 100644 (file)
@@ -862,7 +862,7 @@ static int rt700_set_bias_level(struct snd_soc_component *component,
        default:
                break;
        }
-       dapm->bias_level = level;
+
        return 0;
 }