]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ibmvnic: Process crqs after enabling interrupts
authorSukadev Bhattiprolu <sukadev@linux.ibm.com>
Fri, 29 Oct 2021 22:03:15 +0000 (15:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 13:04:13 +0000 (14:04 +0100)
[ Upstream commit 6e20d00158f31f7631d68b86996b7e951c4451c8 ]

Soon after registering a CRQ it is possible that we get a fail over or
maybe a CRQ_INIT from the VIOS while interrupts were disabled.

Look for any such CRQs after enabling interrupts.

Otherwise we can intermittently fail to bring up ibmvnic adapters during
boot, specially in kexec/kdump kernels.

Fixes: 032c5e82847a ("Driver for IBM System i/p VNIC protocol")
Reported-by: Vaishnavi Bhat <vaish123@in.ibm.com>
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Reviewed-by: Dany Madden <drt@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/ibm/ibmvnic.c

index c470dbc03a23ea4bc6e05f249fb97142125d9830..4f99d97638248c0d32cecc7b1cb14f837cdcef45 100644 (file)
@@ -5185,6 +5185,9 @@ static int init_crq_queue(struct ibmvnic_adapter *adapter)
        crq->cur = 0;
        spin_lock_init(&crq->lock);
 
+       /* process any CRQs that were queued before we enabled interrupts */
+       tasklet_schedule(&adapter->tasklet);
+
        return retrc;
 
 req_irq_failed: