usb: hso: check for return value in hso_serial_common_create()

[ Upstream commit e911e99a0770f760377c263bc7bac1b1593c6147 ]

in case of an error tty_register_device_attr() returns ERR_PTR(),
add IS_ERR() check

Reported-and-tested-by: syzbot+67b2bd0e34f952d0321e@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=67b2bd0e34f952d0321e
Signed-off-by: Rustam Kovhaev <rkovhaev@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index cbbff16d438f58b46c507fd4efd7564cfbc5528c..efd4bf06f6ada741e856449ee437486ad5a534c6 100644 (file)
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -2280,12 +2280,14 @@ static int hso_serial_common_create(struct hso_serial *serial, int num_urbs,
 
        minor = get_free_serial_index();
        if (minor < 0)
-               goto exit;
+               goto exit2;
 
        /* register our minor number */
        serial->parent->dev = tty_port_register_device_attr(&serial->port,
                        tty_drv, minor, &serial->parent->interface->dev,
                        serial->parent, hso_serial_dev_groups);
+       if (IS_ERR(serial->parent->dev))
+               goto exit2;
        dev = serial->parent->dev;
 
        /* fill in specific data for later use */
@@ -2335,6 +2337,7 @@ static int hso_serial_common_create(struct hso_serial *serial, int num_urbs,
        return 0;
 exit:
        hso_serial_tty_unregister(serial);
+exit2:
        hso_serial_common_free(serial);
        return -1;
 }